Make character column always visible #91

Closed
opened 2026-10-15 21:01:23 +00:00 by Syndria98 · 3 comments
Owner

On the character sheet, make that the character column div is always visible when changing tabs of the character sheet

On the character sheet, make that the character column div is always visible when changing tabs of the character sheet
Syndria98 added the ai-ready label 2026-10-15 21:01:23 +00:00
Agent added the working label 2026-10-15 21:42:04 +00:00
Collaborator

Baseline is green (330 tests). Now let me restructure the template so the character column stands outside the tab bodies.

Baseline is green (330 tests). Now let me restructure the template so the character column stands outside the tab bodies.
Collaborator

#91 done — the character column now stands outside the tabs.

What changed

frontend/app/components/windows/CharacterSheetWindow.vue

The column (.character-column: portrait, then armor class / speed / proficiency bonus / initiative and the hit points and hit dice bars) was the first cell of the ability scores tab's grid, so v-show hid it whenever another tab was opened.

  • The column moved out of <main v-show="activeTab === 'abilities'"> and is now a sibling of all four tab bodies inside a new .sheet-layout wrapper, so nothing toggles it.
  • .sheet-layout takes over the grid the abilities tab used to own: minmax(200px, 34%) minmax(0, 1fr) — the character on the left, the open tab beside it. .sheet-tab-body is now grid-column: 2; grid-row: 1 and a flex column, so the ability scores / skills / proficiencies panels stack exactly as before and the four tab bodies share the same cell (only one is displayed at a time).
  • The per-panel grid placement (.abilities-panel, .skills-panel, .proficiencies-panel) and the sheet-grid class went away with it; the narrow-window breakpoint (≤760px) now stacks the column over the tab instead of beside it, still visible, and the tab rail on the window border is untouched.

The column is a normal part of the sheet body, so it scrolls with the sheet; it is no longer hidden by switching tabs, which is what the issue asked for.

Tests

  • Added tests/character-sheet-persistent-column.test.js (issue framing follows the other character sheet tests): the column is not inside any tab body and carries no v-show, the column and every tab body are siblings under .sheet-layout, the grid rules keep them side by side (and stacked, but present, at 760px), and the readouts that stay on screen are named.
  • tests/character-sheet-tabs.test.js: the old assertion "the portrait stays with ability scores" encoded the behaviour the issue removes — it now asserts the portrait belongs to no tab body.
  • tests/character-sheet-portrait-column.test.js: comment only ("the column that opens the abilities tab" → "the column that stands beside every tab"); its assertions were already placement-agnostic.

node --test tests/ → 334 pass, 0 fail (330 before, +4 new). I also compiled the window with @vue/compiler-sfc in a scratch directory: template and scoped style compile without errors. Frontend dependencies are not installed in this tree, so I could not exercise the window in a browser.

**#91 done — the character column now stands outside the tabs.** ## What changed `frontend/app/components/windows/CharacterSheetWindow.vue` The column (`.character-column`: portrait, then armor class / speed / proficiency bonus / initiative and the hit points and hit dice bars) was the first cell of the **ability scores** tab's grid, so `v-show` hid it whenever another tab was opened. - The column moved out of `<main v-show="activeTab === 'abilities'">` and is now a sibling of all four tab bodies inside a new `.sheet-layout` wrapper, so nothing toggles it. - `.sheet-layout` takes over the grid the abilities tab used to own: `minmax(200px, 34%) minmax(0, 1fr)` — the character on the left, the open tab beside it. `.sheet-tab-body` is now `grid-column: 2; grid-row: 1` and a flex column, so the ability scores / skills / proficiencies panels stack exactly as before and the four tab bodies share the same cell (only one is displayed at a time). - The per-panel grid placement (`.abilities-panel`, `.skills-panel`, `.proficiencies-panel`) and the `sheet-grid` class went away with it; the narrow-window breakpoint (≤760px) now stacks the column over the tab instead of beside it, still visible, and the tab rail on the window border is untouched. The column is a normal part of the sheet body, so it scrolls with the sheet; it is no longer hidden by switching tabs, which is what the issue asked for. ## Tests - Added `tests/character-sheet-persistent-column.test.js` (issue framing follows the other character sheet tests): the column is not inside any tab body and carries no `v-show`, the column and every tab body are siblings under `.sheet-layout`, the grid rules keep them side by side (and stacked, but present, at 760px), and the readouts that stay on screen are named. - `tests/character-sheet-tabs.test.js`: the old assertion "the portrait stays with ability scores" encoded the behaviour the issue removes — it now asserts the portrait belongs to no tab body. - `tests/character-sheet-portrait-column.test.js`: comment only ("the column that opens the abilities tab" → "the column that stands beside every tab"); its assertions were already placement-agnostic. `node --test tests/` → 334 pass, 0 fail (330 before, +4 new). I also compiled the window with `@vue/compiler-sfc` in a scratch directory: template and scoped style compile without errors. Frontend dependencies are not installed in this tree, so I could not exercise the window in a browser.
Collaborator

Implementation is ready for review: #94

Implementation is ready for review: https://git.aranroig.com/Syndria98/dragonroll/pulls/94
Agent added help wanted and removed working labels 2026-10-15 21:56:50 +00:00
Sign in to join this conversation.
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Syndria98/dragonroll#91