Style corrections on /docs #85
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I'll start by exploring the docs view and its styles.
Now I understand the layout. Let me apply the style corrections.
Now let me add tests that lock these layout corrections, in the style of the existing docs tests.
Done. Here's what I changed and verified.
Changes
frontend/app/components/views/DocsView.vue(styles only)Sidebar now as tall as the page — the shared
.docs-sidebar, .docs-sectionsrule hadmax-height: 100vh, so with the row'salign-items: flex-starteach aside was only as tall as its own contents and its background/border-rightstopped short. They now getheight: 100vh(stillposition: sticky; top: 0), so the column and its border run to the bottom at every scroll position. The stackedmax-width: 900pxoverride was updated frommax-height: nonetoheight: autoto match.Content centred on wide windows — the reading column (
.docs-article, and.docs-pagerwith it) is nowwidth: 100%; max-width: 760px; margin-inline: auto, so the text sits in the middle of the space beside the sidebar instead of hugging it. In addition, a@media (min-width: 1440px)rule centres the whole row (justify-content: center) and stops.docs-mainfrom growing (flex: 0 1 860px)..docs-sectionshas more padding, closer to the content — its ownpadding: 26px 22px 26px 18px(was the shared18px 14px), width 220px → 240px so the links don't lose line room, and because the main column stops growing on wide windows the aside now sits right next to the text rather than out at the right edge of the screen.tests/docs.test.js— added a section for #85 that reads the component's<style>block as rules (no stylesheet dependency at the repo root) and asserts: both asides are sticky andheight: 100vh(nomax-height), the narrow stacked layout releases that height, the reading column is width-capped andmargin-inline: auto, one wide-window rule centres the row with a capped main column and a threshold ≥ 1400px, and the sections aside's padding is at least the shared padding on every side and greater on at least one.Verification
npm testfrom the repo root: 305 tests, 305 pass, 0 fail (includes the 5 new layout tests).sass— it compiles cleanly.pnpm devto eyeball the page in a browser (workspace dependencies aren't installed in this environment), so the layout is verified by the tests and the compiled CSS rather than visually.Implementation is ready for review: #88