Style corrections on /docs #85

Closed
opened 2026-10-15 19:58:20 +00:00 by Syndria98 · 5 comments
Owner
  • The aside with class docs-sidebar is not as tall as the entire page. Fix it
  • If the window size is very wide make the content centered.
  • Make the aside .docs-section with more padding and closer to the content
- The aside with class docs-sidebar is not as tall as the entire page. Fix it - If the window size is very wide make the content centered. - Make the aside .docs-section with more padding and closer to the content
Syndria98 added the ai-ready label 2026-10-15 19:58:20 +00:00
Agent added the working label 2026-10-15 20:44:59 +00:00
Collaborator

I'll start by exploring the docs view and its styles.

I'll start by exploring the docs view and its styles.
Collaborator

Now I understand the layout. Let me apply the style corrections.

Now I understand the layout. Let me apply the style corrections.
Collaborator

Now let me add tests that lock these layout corrections, in the style of the existing docs tests.

Now let me add tests that lock these layout corrections, in the style of the existing docs tests.
Collaborator

Done. Here's what I changed and verified.

Changes

frontend/app/components/views/DocsView.vue (styles only)

  1. Sidebar now as tall as the page — the shared .docs-sidebar, .docs-sections rule had max-height: 100vh, so with the row's align-items: flex-start each aside was only as tall as its own contents and its background/border-right stopped short. They now get height: 100vh (still position: sticky; top: 0), so the column and its border run to the bottom at every scroll position. The stacked max-width: 900px override was updated from max-height: none to height: auto to match.

  2. Content centred on wide windows — the reading column (.docs-article, and .docs-pager with it) is now width: 100%; max-width: 760px; margin-inline: auto, so the text sits in the middle of the space beside the sidebar instead of hugging it. In addition, a @media (min-width: 1440px) rule centres the whole row (justify-content: center) and stops .docs-main from growing (flex: 0 1 860px).

  3. .docs-sections has more padding, closer to the content — its own padding: 26px 22px 26px 18px (was the shared 18px 14px), width 220px → 240px so the links don't lose line room, and because the main column stops growing on wide windows the aside now sits right next to the text rather than out at the right edge of the screen.

tests/docs.test.js — added a section for #85 that reads the component's <style> block as rules (no stylesheet dependency at the repo root) and asserts: both asides are sticky and height: 100vh (no max-height), the narrow stacked layout releases that height, the reading column is width-capped and margin-inline: auto, one wide-window rule centres the row with a capped main column and a threshold ≥ 1400px, and the sections aside's padding is at least the shared padding on every side and greater on at least one.

Verification

  • npm test from the repo root: 305 tests, 305 pass, 0 fail (includes the 5 new layout tests).
  • Compiled the component's stylesheet with a standalone sass — it compiles cleanly.
  • I did not run pnpm dev to eyeball the page in a browser (workspace dependencies aren't installed in this environment), so the layout is verified by the tests and the compiled CSS rather than visually.
Done. Here's what I changed and verified. ## Changes **`frontend/app/components/views/DocsView.vue`** (styles only) 1. **Sidebar now as tall as the page** — the shared `.docs-sidebar, .docs-sections` rule had `max-height: 100vh`, so with the row's `align-items: flex-start` each aside was only as tall as its own contents and its background/`border-right` stopped short. They now get `height: 100vh` (still `position: sticky; top: 0`), so the column and its border run to the bottom at every scroll position. The stacked `max-width: 900px` override was updated from `max-height: none` to `height: auto` to match. 2. **Content centred on wide windows** — the reading column (`.docs-article`, and `.docs-pager` with it) is now `width: 100%; max-width: 760px; margin-inline: auto`, so the text sits in the middle of the space beside the sidebar instead of hugging it. In addition, a `@media (min-width: 1440px)` rule centres the whole row (`justify-content: center`) and stops `.docs-main` from growing (`flex: 0 1 860px`). 3. **`.docs-sections` has more padding, closer to the content** — its own `padding: 26px 22px 26px 18px` (was the shared `18px 14px`), width 220px → 240px so the links don't lose line room, and because the main column stops growing on wide windows the aside now sits right next to the text rather than out at the right edge of the screen. **`tests/docs.test.js`** — added a section for #85 that reads the component's `<style>` block as rules (no stylesheet dependency at the repo root) and asserts: both asides are sticky and `height: 100vh` (no `max-height`), the narrow stacked layout releases that height, the reading column is width-capped *and* `margin-inline: auto`, one wide-window rule centres the row with a capped main column and a threshold ≥ 1400px, and the sections aside's padding is at least the shared padding on every side and greater on at least one. ## Verification - `npm test` from the repo root: **305 tests, 305 pass, 0 fail** (includes the 5 new layout tests). - Compiled the component's stylesheet with a standalone `sass` — it compiles cleanly. - I did not run `pnpm dev` to eyeball the page in a browser (workspace dependencies aren't installed in this environment), so the layout is verified by the tests and the compiled CSS rather than visually.
Collaborator

Implementation is ready for review: #88

Implementation is ready for review: https://git.aranroig.com/Syndria98/dragonroll/pulls/88
Agent added the help wanted label 2026-10-15 20:55:08 +00:00
Agent removed the working label 2026-10-15 20:55:08 +00:00
Sign in to join this conversation.
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Syndria98/dragonroll#85