Add more things to the character sheet #83

Closed
opened 2026-10-15 19:41:24 +00:00 by Syndria98 · 8 comments
Owner
  • Add a list with the skills (acrobatics, animal handling, arcana, ....) and a circle toggle button on each to toggle if it is proficient, on the ability scores tab
  • Also add information about the saving throws on the ability scores tab
  • Also include proficencies with tools and with languages
  • On the inventory, show also the currency that the character holds, and add the item icon on the left of each entry
  • Also make the traits tab sync
- Add a list with the skills (acrobatics, animal handling, arcana, ....) and a circle toggle button on each to toggle if it is proficient, on the ability scores tab - Also add information about the saving throws on the ability scores tab - Also include proficencies with tools and with languages - On the inventory, show also the currency that the character holds, and add the item icon on the left of each entry - Also make the traits tab sync
Syndria98 added the ai-ready label 2026-10-15 19:41:24 +00:00
Agent added the working label 2026-10-15 19:41:25 +00:00
Collaborator

Now let me implement. Starting with the backend model:

Now let me implement. Starting with the backend model:
Collaborator

Now the Foundry → Dragonroll mapper:

Now the Foundry → Dragonroll mapper:
Collaborator

Now the frontend sheet — script section first:

Now the frontend sheet — script section first:
Collaborator

Now the test file for the issue:

Now the test file for the issue:
Collaborator

All 324 tests pass. Final review of the diff:

All 324 tests pass. Final review of the diff:
Collaborator

Everything is complete and verified. Final state of the work for issue #83:

Character sheet — new sections (CharacterSheetWindow.vue)

  • Skills: the 18 standard skills with their governing ability, a modifier next to each, and a proficiency circle you click to toggle (in the abilities tab, next to a new Saving Throws block that shows all six with modifiers).
  • Tools & Languages: in the Proficiencies tab, each a toggle-circle list plus a free-text area for custom entries (newline-separated), shown as chips with a remove button.
  • Inventory: a pp/gp/ep/sp/cp currency row above the table, an icon column (Foundry icons and uploaded images resolve; plain names show the item initial), and the image button in the detail form can now set an item icon.
  • Traits: the tab now shows content. The world's system.details.trait text or trait feats sync in, and text you write in Dragonroll is kept and travels with the actor snapshot.
  • All editing keeps the existing draft/Save model; circles are disabled outside edit mode.

Sync (actor-foundry.js, module api.js)

  • The mapper reads skill/tool proficiency in every shape dnd5e uses (true, 2, "base", [1,2], {value}), saving throws from abilities.*.save, system.currency, and item images; the module resolves tool/language keys to their world labels before sending.
  • A field is only written when Foundry actually says something about it, so a live event can never clear what you set in the campaign; a renamed world skill stays in sync.

Backend: the Actor model and /actor/update accept skills, savingThrows, tools, languages, currency and inventory[].icon (lists deduped, currencies clamped, traits accept free text).

Strings added to all three locales (en/es/ca); docs updated (character tabs, currency/icons, Foundry "What syncs").

Tests: new tests/character-sheet-details.test.js (24 tests covering model, route, mapper edge cases, the module's actor snapshot, the sheet, and locale completeness); existing portrait-column fixtures adjusted. Full suite: 324/324 passing.

Everything is complete and verified. Final state of the work for issue #83: **Character sheet — new sections** (`CharacterSheetWindow.vue`) - **Skills**: the 18 standard skills with their governing ability, a modifier next to each, and a proficiency circle you click to toggle (in the abilities tab, next to a new **Saving Throws** block that shows all six with modifiers). - **Tools & Languages**: in the Proficiencies tab, each a toggle-circle list plus a free-text area for custom entries (newline-separated), shown as chips with a remove button. - **Inventory**: a pp/gp/ep/sp/cp currency row above the table, an icon column (Foundry icons and uploaded images resolve; plain names show the item initial), and the image button in the detail form can now set an item icon. - **Traits**: the tab now shows content. The world's `system.details.trait` text or trait feats sync in, and text you write in Dragonroll is kept and travels with the actor snapshot. - All editing keeps the existing draft/Save model; circles are disabled outside edit mode. **Sync** (`actor-foundry.js`, module `api.js`) - The mapper reads skill/tool proficiency in every shape dnd5e uses (`true`, `2`, `"base"`, `[1,2]`, `{value}`), saving throws from `abilities.*.save`, `system.currency`, and item images; the module resolves tool/language keys to their world labels before sending. - A field is only written when Foundry actually says something about it, so a live event can never clear what you set in the campaign; a renamed world skill stays in sync. **Backend**: the `Actor` model and `/actor/update` accept `skills`, `savingThrows`, `tools`, `languages`, `currency` and `inventory[].icon` (lists deduped, currencies clamped, traits accept free text). **Strings** added to all three locales (en/es/ca); docs updated (character tabs, currency/icons, Foundry "What syncs"). **Tests**: new `tests/character-sheet-details.test.js` (24 tests covering model, route, mapper edge cases, the module's actor snapshot, the sheet, and locale completeness); existing portrait-column fixtures adjusted. Full suite: **324/324 passing**.
Collaborator

Implementation is ready for review: #86

Implementation is ready for review: https://git.aranroig.com/Syndria98/dragonroll/pulls/86
Collaborator

The automated implementation stopped because of an internal error. Please check the worker logs for details.

The automated implementation stopped because of an internal error. Please check the worker logs for details.
Agent removed the working label 2026-10-15 20:40:05 +00:00
Sign in to join this conversation.
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Syndria98/dragonroll#83