Compare commits
1 Commits
6df7d57376
...
ai/issue-6
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
b47bbb4cab |
@@ -117,7 +117,7 @@ the JWT guard; CORS opened for it): `snapshot` (actors + world items, `fullSync`
|
|||||||
`item-snapshot`, `item-delete`, `characters`, `items`, `status`, `map` / `map-item`, `delete`. Rules:
|
`item-snapshot`, `item-delete`, `characters`, `items`, `status`, `map` / `map-item`, `delete`. Rules:
|
||||||
|
|
||||||
- **Identity** is `foundryActorId` / `foundryItemId` (unique per campaign, partial index); a Foundry document carrying the `dragonroll-foundry.actorId` / `.itemId` flag adopts the matching Dragonroll row.
|
- **Identity** is `foundryActorId` / `foundryItemId` (unique per campaign, partial index); a Foundry document carrying the `dragonroll-foundry.actorId` / `.itemId` flag adopts the matching Dragonroll row.
|
||||||
- **Only the world's item directory reaches the item list** (Syndria98/dragonroll#67) — `snapshotItemSources` reads `body.items` (`game.items`) alone; gear embedded in a character is that actor's `inventory` (see the `Actor` model), not an `Item`. A world item still folds into a hand-made or renamed row it matches by name (`foundryNames`), so a rename does not resurrect a duplicate. `services/item-foundry.js` returns `null` for non-gear types and those are skipped.
|
- **Items are deduplicated by name** — Foundry keeps the same gear once per carrier, so one `Item` per name; `foundryNames` keeps Foundry's names so a Dragonroll rename does not resurrect a duplicate. `services/item-foundry.js` returns `null` for non-gear types and those are skipped.
|
||||||
- **Item folders mirror the world's item directory** (`Folder.foundryFolderId`, target `item`): every push carries the whole tree and the world owns its names and nesting. `color` is the one field the campaign sets too, so it travels back with the folders `GET /foundry/sync/items` answers with (`{items, folders}`) and the module writes it onto the world's folder.
|
- **Item folders mirror the world's item directory** (`Folder.foundryFolderId`, target `item`): every push carries the whole tree and the world owns its names and nesting. `color` is the one field the campaign sets too, so it travels back with the folders `GET /foundry/sync/items` answers with (`{items, folders}`) and the module writes it onto the world's folder.
|
||||||
- **`fullSync` preserves Dragonroll edits** (only new rows are overwritten); live Foundry events overwrite. Only a full snapshot can prune.
|
- **`fullSync` preserves Dragonroll edits** (only new rows are overwritten); live Foundry events overwrite. Only a full snapshot can prune.
|
||||||
- **Autosync is a Foundry-side setting** (`autoSync`, on by default): off = no CRUD push, no periodic reconcile, no startup snapshot; the actor directory's *Dragonroll: Force Sync* still upserts the selection (`fullSync:false`).
|
- **Autosync is a Foundry-side setting** (`autoSync`, on by default): off = no CRUD push, no periodic reconcile, no startup snapshot; the actor directory's *Dragonroll: Force Sync* still upserts the selection (`fullSync:false`).
|
||||||
|
|||||||
@@ -22,17 +22,6 @@ const ActorSchema = new Schema({
|
|||||||
},
|
},
|
||||||
armorClass: { type: Number, min: 0, default: 10 },
|
armorClass: { type: Number, min: 0, default: 10 },
|
||||||
speed: { type: Number, min: 0, default: 30 },
|
speed: { type: Number, min: 0, default: 30 },
|
||||||
// The two pools the sheet draws as bars under the portrait (Syndria98/dragonroll#64): the bar
|
|
||||||
// fills `current` of `max`, so both travel together. `current` is kept below `max` by whoever
|
|
||||||
// writes them (routes/actor.js), the same way the sheet clamps the bar.
|
|
||||||
hitPoints: {
|
|
||||||
current: { type: Number, min: 0, default: 10 },
|
|
||||||
max: { type: Number, min: 0, default: 10 }
|
|
||||||
},
|
|
||||||
hitDice: {
|
|
||||||
current: { type: Number, min: 0, default: 1 },
|
|
||||||
max: { type: Number, min: 0, default: 1 }
|
|
||||||
},
|
|
||||||
proficiencies: { type: String, default: '' },
|
proficiencies: { type: String, default: '' },
|
||||||
inventory: [{
|
inventory: [{
|
||||||
name: { type: String, trim: true, default: '' },
|
name: { type: String, trim: true, default: '' },
|
||||||
|
|||||||
@@ -13,15 +13,6 @@ async function userOwnsCampaign(campaignId, userId) {
|
|||||||
return Boolean(campaign);
|
return Boolean(campaign);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Hit points and hit dice travel as a bar the sheet fills (`current` of `max`, see models/Actor.js).
|
|
||||||
// A partial update keeps whatever half of the pair it did not send, and `current` never passes the
|
|
||||||
// maximum it ends up with.
|
|
||||||
function barPool(existing, value) {
|
|
||||||
const max = Math.max(0, Number(value?.max ?? existing?.max) || 0);
|
|
||||||
const current = Math.max(0, Math.min(Number(value?.current ?? existing?.current) || 0, max));
|
|
||||||
return { current, max };
|
|
||||||
}
|
|
||||||
|
|
||||||
// Folders the campaign's actors are grouped into, in the shape the sidebar groups by
|
// Folders the campaign's actors are grouped into, in the shape the sidebar groups by
|
||||||
// (the notes, items and maps each keep a tree of their own, see models/Folder.js).
|
// (the notes, items and maps each keep a tree of their own, see models/Folder.js).
|
||||||
async function actorFolders(campaignId) {
|
async function actorFolders(campaignId) {
|
||||||
@@ -65,7 +56,7 @@ router.post('/create', async (req, res) => {
|
|||||||
|
|
||||||
router.post('/update', async (req, res) => {
|
router.post('/update', async (req, res) => {
|
||||||
try {
|
try {
|
||||||
const { id, name, species, className, subclass, level, abilityScores, armorClass, speed, hitPoints, hitDice, proficiencies, inventory, traits, spells, image, folder } = req.body;
|
const { id, name, species, className, subclass, level, abilityScores, armorClass, speed, proficiencies, inventory, traits, spells, image, folder } = req.body;
|
||||||
if (!id) return res.json({ status: 'error', msg: 'errors.missing-data' });
|
if (!id) return res.json({ status: 'error', msg: 'errors.missing-data' });
|
||||||
|
|
||||||
const actor = await Actor.findById(id);
|
const actor = await Actor.findById(id);
|
||||||
@@ -89,8 +80,6 @@ router.post('/update', async (req, res) => {
|
|||||||
if (abilityScores !== undefined) actor.abilityScores = abilityScores;
|
if (abilityScores !== undefined) actor.abilityScores = abilityScores;
|
||||||
if (armorClass !== undefined) actor.armorClass = Number(armorClass);
|
if (armorClass !== undefined) actor.armorClass = Number(armorClass);
|
||||||
if (speed !== undefined) actor.speed = Number(speed);
|
if (speed !== undefined) actor.speed = Number(speed);
|
||||||
if (hitPoints !== undefined) actor.hitPoints = barPool(actor.hitPoints, hitPoints);
|
|
||||||
if (hitDice !== undefined) actor.hitDice = barPool(actor.hitDice, hitDice);
|
|
||||||
if (proficiencies !== undefined) actor.proficiencies = proficiencies;
|
if (proficiencies !== undefined) actor.proficiencies = proficiencies;
|
||||||
if (inventory !== undefined) actor.inventory = inventory;
|
if (inventory !== undefined) actor.inventory = inventory;
|
||||||
if (traits !== undefined) actor.traits = traits;
|
if (traits !== undefined) actor.traits = traits;
|
||||||
|
|||||||
@@ -69,13 +69,17 @@ async function saveFoundryActor(campaign, source, fullSync = false) {
|
|||||||
return { foundryActorId, actorId: actor.id };
|
return { foundryActorId, actorId: actor.id };
|
||||||
}
|
}
|
||||||
|
|
||||||
// The campaign's item list mirrors the world's item directory and nothing else
|
// A snapshot carries world-level items plus the items embedded in every actor it
|
||||||
// (Syndria98/dragonroll#67). The items embedded in an actor are that character's own
|
// sends. World items are listed first so they own a name before its copies.
|
||||||
// inventory: they travel with the actor document (see services/actor-foundry.js), so a
|
|
||||||
// snapshot feeds Item rows from the world directory (`body.items`) alone and gear a
|
|
||||||
// character merely carries stays on its sheet instead of standing in the item list.
|
|
||||||
function snapshotItemSources(body) {
|
function snapshotItemSources(body) {
|
||||||
return Array.isArray(body.items) ? body.items : [];
|
const sources = [];
|
||||||
|
if (Array.isArray(body.items)) sources.push(...body.items);
|
||||||
|
if (Array.isArray(body.actors)) {
|
||||||
|
for (const actor of body.actors) {
|
||||||
|
if (Array.isArray(actor?.items)) sources.push(...actor.items);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return sources;
|
||||||
}
|
}
|
||||||
|
|
||||||
async function saveFoundryItem(campaign, source, fullSync = false, folders = null) {
|
async function saveFoundryItem(campaign, source, fullSync = false, folders = null) {
|
||||||
@@ -91,9 +95,9 @@ async function saveFoundryItem(campaign, source, fullSync = false, folders = nul
|
|||||||
if (flagged && (!flagged.foundryItemId || flagged.foundryItemId === foundryItemId)) item = flagged;
|
if (flagged && (!flagged.foundryItemId || flagged.foundryItemId === foundryItemId)) item = flagged;
|
||||||
}
|
}
|
||||||
if (!item) {
|
if (!item) {
|
||||||
// A world item can share its name with a Dragonroll row the campaign made by
|
// The same gear exists more than once in Foundry: once in the world
|
||||||
// hand, or with one it renamed away from. Keep a single item per name so a
|
// directory and once inside each actor carrying it. Keep a single
|
||||||
// piece of gear the world sends folds into that row instead of doubling it.
|
// Dragonroll item per name so inventories do not flood the Item list.
|
||||||
const sameName = await Item.find({
|
const sameName = await Item.find({
|
||||||
campaign: campaign._id,
|
campaign: campaign._id,
|
||||||
$or: [{ name: fields.name }, { foundryNames: fields.name }]
|
$or: [{ name: fields.name }, { foundryNames: fields.name }]
|
||||||
@@ -113,10 +117,10 @@ async function saveFoundryItem(campaign, source, fullSync = false, folders = nul
|
|||||||
item.foundryNames = [...item.foundryNames, fields.name].slice(-MAX_FOUNDRY_NAMES);
|
item.foundryNames = [...item.foundryNames, fields.name].slice(-MAX_FOUNDRY_NAMES);
|
||||||
}
|
}
|
||||||
// Which folder of the campaign's item tree the world says this item stands in.
|
// Which folder of the campaign's item tree the world says this item stands in.
|
||||||
// `undefined` means the push says nothing about folders — an older module that
|
// `undefined` means the push says nothing about folders — an item embedded in an
|
||||||
// knows nothing about them — and the item stays where it is. The world owns the
|
// actor, or a module that knows nothing about them — and the item stays where it
|
||||||
// folder of its own directory, so a move it reports lands on a full snapshot too
|
// is. The world owns the folder of its own directory, so a move it reports lands on
|
||||||
// and wins over one a campaign made from its item list.
|
// a full snapshot too and wins over one a campaign made from its item list.
|
||||||
const folder = resolveFoundryItemFolder(source, folders);
|
const folder = resolveFoundryItemFolder(source, folders);
|
||||||
if (folder !== undefined) item.folder = folder;
|
if (folder !== undefined) item.folder = folder;
|
||||||
await item.save();
|
await item.save();
|
||||||
@@ -136,9 +140,9 @@ async function syncFoundryItems(campaign, sources, fullSync = false, folders = n
|
|||||||
// A Foundry world groups its item directory into folders; the campaign mirrors that
|
// A Foundry world groups its item directory into folders; the campaign mirrors that
|
||||||
// tree as Folders of target 'item' so its item list reads like the world's. Every
|
// tree as Folders of target 'item' so its item list reads like the world's. Every
|
||||||
// push from a module that knows about folders carries the whole world tree, and
|
// push from a module that knows about folders carries the whole world tree, and
|
||||||
// names the folder each world item it sends stands in. Only the world's item
|
// names the folder each world item it sends stands in. Items embedded in an actor
|
||||||
// directory reaches the campaign's item list, so only its folders are mirrored; the
|
// say nothing: the folders they carry belong to that actor's own inventory, and
|
||||||
// inventory folders an actor keeps for itself are none of the item list's business.
|
// Dragonroll keeps one item per piece of gear anyway.
|
||||||
|
|
||||||
// The colour a pushed folder carries. `undefined` means the push says nothing about
|
// The colour a pushed folder carries. `undefined` means the push says nothing about
|
||||||
// colours — an older module, which knows nothing about them — and the colour the
|
// colours — an older module, which knows nothing about them — and the colour the
|
||||||
@@ -293,8 +297,8 @@ router.post('/sync/snapshot', async (req, res) => {
|
|||||||
foundryActorId: { $exists: true, $nin: currentIds }
|
foundryActorId: { $exists: true, $nin: currentIds }
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
// Pruning needs a full snapshot: only that request sees the whole world
|
// Pruning needs a full snapshot: only that request sees the world
|
||||||
// directory, so it alone knows which synced rows the world has let go of.
|
// directory and every actor's copies at the same time.
|
||||||
if (fullSync && itemSources) {
|
if (fullSync && itemSources) {
|
||||||
const currentIds = snapshotItemSources(req.body)
|
const currentIds = snapshotItemSources(req.body)
|
||||||
.map((source) => String(source?._id || source?.id || '').trim())
|
.map((source) => String(source?._id || source?.id || '').trim())
|
||||||
|
|||||||
@@ -82,16 +82,16 @@ The optional read-only snapshot bridge is not affected: it keeps publishing the
|
|||||||
|
|
||||||
### Items
|
### Items
|
||||||
|
|
||||||
The campaign's Item list mirrors the world's item directory (Foundry's **items tab**) and nothing
|
The campaign's Item list is synchronized with the world's gear, both ways:
|
||||||
else (Syndria98/dragonroll#67):
|
|
||||||
|
|
||||||
- The GM sends the world item directory (`game.items`) with every snapshot, and world items created,
|
- The GM sends the world item directory (`game.items`) with every snapshot, and world items created,
|
||||||
changed or deleted in Foundry are pushed as they happen. The items embedded in a character are that
|
changed or deleted in Foundry are pushed as they happen. Items embedded in a character travel with
|
||||||
character's own inventory: they travel with its snapshot and stay on its sheet, so gear a character
|
that character's snapshot instead.
|
||||||
merely carries does not stand in the campaign's item list.
|
- Gear is deduplicated by name: the same sword in the world directory and in three characters'
|
||||||
- A world item folds into a Dragonroll row that already carries its name — one a campaign made by hand,
|
inventories becomes one Dragonroll item. Names Dragonroll renames away from are remembered on the
|
||||||
or one it renamed away from and remembers (`foundryNames`) — instead of doubling it. Spells, classes,
|
item (`foundryNames`), so Foundry's copies keep folding into it rather than coming back as a
|
||||||
subclasses, backgrounds, feats and species are not gear and are not imported.
|
duplicate. Spells, classes, subclasses, backgrounds, feats and species are not gear and are not
|
||||||
|
imported.
|
||||||
- Foundry owns the fields it sends (category from the item type, rarity, quantity, weight, weapon
|
- Foundry owns the fields it sends (category from the item type, rarity, quantity, weight, weapon
|
||||||
properties, description). An item made by hand in Dragonroll is created in the world's item
|
properties, description). An item made by hand in Dragonroll is created in the world's item
|
||||||
directory on the next reconcile, mapped afterwards, and editing it in Dragonroll updates the Foundry
|
directory on the next reconcile, mapped afterwards, and editing it in Dragonroll updates the Foundry
|
||||||
@@ -101,9 +101,10 @@ else (Syndria98/dragonroll#67):
|
|||||||
what the GM colours in Foundry shows on the campaign's folder, and what the campaign colours lands on
|
what the GM colours in Foundry shows on the campaign's folder, and what the campaign colours lands on
|
||||||
the world's folder on the next reconcile (the world's document keeps its name and nesting either way).
|
the world's folder on the next reconcile (the world's document keeps its name and nesting either way).
|
||||||
- A full snapshot keeps Dragonroll edits on reconnect; live Foundry edits overwrite. Item removal is
|
- A full snapshot keeps Dragonroll edits on reconnect; live Foundry edits overwrite. Item removal is
|
||||||
pruned only by a full snapshot, so a live item push never deletes anything: only a full snapshot sees
|
pruned only by a full snapshot, so a live item push never deletes anything. Deleting a synced item in
|
||||||
the whole world directory and can tell which synced rows it has let go of. Deleting a synced item in
|
Dragonroll removes its Foundry world copy on the next reconcile. Items that live only in an actor's
|
||||||
Dragonroll removes its Foundry world copy on the next reconcile.
|
inventory are owned by that actor's snapshot: editing such an item in Dragonroll does not rewrite the
|
||||||
|
actor's copy.
|
||||||
|
|
||||||
The module calls these Dragonroll routes with the campaign sync token (no Dragonroll login):
|
The module calls these Dragonroll routes with the campaign sync token (no Dragonroll login):
|
||||||
|
|
||||||
|
|||||||
@@ -23,7 +23,6 @@ let updatingPairingStatus = false;
|
|||||||
let linkedCampaignName = "";
|
let linkedCampaignName = "";
|
||||||
let linkProblem = "";
|
let linkProblem = "";
|
||||||
let actorSyncTimeout;
|
let actorSyncTimeout;
|
||||||
let characterSyncRetryTimeout;
|
|
||||||
let characterSyncRunning = false;
|
let characterSyncRunning = false;
|
||||||
let actorSyncErrorLogged = false;
|
let actorSyncErrorLogged = false;
|
||||||
const syncingActorIds = new Set();
|
const syncingActorIds = new Set();
|
||||||
@@ -530,9 +529,8 @@ async function pushFoundryActors(actors, fullSync = false) {
|
|||||||
const result = await postDragonroll("foundry/sync/snapshot", {
|
const result = await postDragonroll("foundry/sync/snapshot", {
|
||||||
worldId: game.world.id,
|
worldId: game.world.id,
|
||||||
actors: supportedActors.map(serializeFoundryActor),
|
actors: supportedActors.map(serializeFoundryActor),
|
||||||
// The world item directory is what the campaign lists as its items
|
// Dragonroll deduplicates by name, so sending the world directory next to
|
||||||
// (Syndria98/dragonroll#67); the gear a character carries travels inside that
|
// the actor copies keeps a single Item per piece of gear.
|
||||||
// actor's snapshot as its inventory, not as campaign items.
|
|
||||||
items: getWorldItemSnapshots(),
|
items: getWorldItemSnapshots(),
|
||||||
// The folder tree those world items stand in (see worldItemFolderSnapshots).
|
// The folder tree those world items stand in (see worldItemFolderSnapshots).
|
||||||
folders: worldItemFolderSnapshots(),
|
folders: worldItemFolderSnapshots(),
|
||||||
@@ -1271,14 +1269,6 @@ async function reconcileDragonrollCharacters() {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Both sides converge on a timer that only runs while the world is open, so a
|
|
||||||
// round that could not reach Dragonroll is asked for again in a while instead of
|
|
||||||
// leaving the campaign with whatever it happened to receive.
|
|
||||||
function scheduleDragonrollCharacterSync(delay = 15000) {
|
|
||||||
clearTimeout(characterSyncRetryTimeout);
|
|
||||||
characterSyncRetryTimeout = setTimeout(reconcileDragonrollCharacters, delay);
|
|
||||||
}
|
|
||||||
|
|
||||||
async function initializeCharacterSync() {
|
async function initializeCharacterSync() {
|
||||||
if (!getSyncToken() || !game.user?.isGM || !game.world || !isAutoSyncEnabled()) return;
|
if (!getSyncToken() || !game.user?.isGM || !game.world || !isAutoSyncEnabled()) return;
|
||||||
try {
|
try {
|
||||||
|
|||||||
@@ -30,19 +30,9 @@ $themes: (
|
|||||||
container-shadow: #151d28,
|
container-shadow: #151d28,
|
||||||
sticky-header-bg: #20202077,
|
sticky-header-bg: #20202077,
|
||||||
|
|
||||||
// Quoted: red/green/gray are also Sass colour keywords, so unquoted they are parsed as
|
red: #e06c75,
|
||||||
// colour values, and interpolating one into `--color-#{$name}` warns
|
green: #98c379,
|
||||||
// (Syndria98/dragonroll#71).
|
gray: #cccccc,
|
||||||
"red": #e06c75,
|
|
||||||
"green": #98c379,
|
|
||||||
"gray": #cccccc,
|
|
||||||
|
|
||||||
// The rarity of an item colours its row in the sidebar (Syndria98/dragonroll#63).
|
|
||||||
rarity-common: #ffffff,
|
|
||||||
rarity-uncommon: #1eff00,
|
|
||||||
rarity-rare: #2f81f7,
|
|
||||||
rarity-very-rare: #a855f7,
|
|
||||||
rarity-legendary: #ff8000,
|
|
||||||
|
|
||||||
icon-invert: 100%,
|
icon-invert: 100%,
|
||||||
|
|
||||||
@@ -78,17 +68,9 @@ $themes: (
|
|||||||
container-shadow: #5f6774,
|
container-shadow: #5f6774,
|
||||||
sticky-header-bg: #fff,
|
sticky-header-bg: #fff,
|
||||||
|
|
||||||
// Quoted for the same reason as in the dark map.
|
red: #e06c75,
|
||||||
"red": #e06c75,
|
green: #98c379,
|
||||||
"green": #98c379,
|
gray: #cccccc,
|
||||||
"gray": #cccccc,
|
|
||||||
|
|
||||||
// Same rarities as the dark map, darkened to stay readable on a light background.
|
|
||||||
rarity-common: #1e1e1e,
|
|
||||||
rarity-uncommon: #157f2b,
|
|
||||||
rarity-rare: #1d4ed8,
|
|
||||||
rarity-very-rare: #7e22ce,
|
|
||||||
rarity-legendary: #c05621,
|
|
||||||
|
|
||||||
icon-invert: 0%,
|
icon-invert: 0%,
|
||||||
|
|
||||||
|
|||||||
@@ -279,13 +279,8 @@ function entrySummary(actor) {
|
|||||||
return bits.join(' · ');
|
return bits.join(' · ');
|
||||||
}
|
}
|
||||||
|
|
||||||
// The rarity of an item colours the text of its row instead of listing category, rarity and
|
function itemSummary(item) {
|
||||||
// quantity (Syndria98/dragonroll#63): common white, uncommon green, rare blue, very rare purple,
|
return `${t(`campaigns.item.categories.${item.category}`)} · ${t(`campaigns.item.rarities.${item.rarity}`)} · ${t('campaigns.item.quantity-short')} ${item.quantity}`;
|
||||||
// legendary orange. Anything else (artifact) keeps the default text colour.
|
|
||||||
function rarityClass(item) {
|
|
||||||
return ['common', 'uncommon', 'rare', 'very-rare', 'legendary'].includes(item.rarity)
|
|
||||||
? `rarity-${item.rarity}`
|
|
||||||
: '';
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// An item's icon in the sidebar: an uploaded filename served from /api/public, or a full URL
|
// An item's icon in the sidebar: an uploaded filename served from /api/public, or a full URL
|
||||||
@@ -686,8 +681,9 @@ onBeforeUnmount(() => {
|
|||||||
<span v-if="row.item.image" class="entity-entry-image" aria-hidden="true">
|
<span v-if="row.item.image" class="entity-entry-image" aria-hidden="true">
|
||||||
<img :src="itemImageUrl(row.item.image)" alt="">
|
<img :src="itemImageUrl(row.item.image)" alt="">
|
||||||
</span>
|
</span>
|
||||||
<span class="entity-entry-name" :class="rarityClass(row.item)">{{ row.item.name }}</span>
|
<span class="entity-entry-name">{{ row.item.name }}</span>
|
||||||
</span>
|
</span>
|
||||||
|
<span class="entity-entry-meta">{{ itemSummary(row.item) }}</span>
|
||||||
</div>
|
</div>
|
||||||
</template>
|
</template>
|
||||||
</template>
|
</template>
|
||||||
@@ -881,13 +877,6 @@ onBeforeUnmount(() => {
|
|||||||
/* An item row leads with the item's own icon on the left of its name, standing in for the
|
/* An item row leads with the item's own icon on the left of its name, standing in for the
|
||||||
"SYNCED" text it used to show (Syndria98/dragonroll#53). */
|
"SYNCED" text it used to show (Syndria98/dragonroll#53). */
|
||||||
.entity-entry-title { display: flex; align-items: center; gap: 9px; min-width: 0; }
|
.entity-entry-title { display: flex; align-items: center; gap: 9px; min-width: 0; }
|
||||||
/* The rarity of an item colours the text of its row (Syndria98/dragonroll#63): common white,
|
|
||||||
uncommon green, rare blue, very rare purple, legendary orange. */
|
|
||||||
.entity-entry-name.rarity-common { color: var(--color-rarity-common); }
|
|
||||||
.entity-entry-name.rarity-uncommon { color: var(--color-rarity-uncommon); }
|
|
||||||
.entity-entry-name.rarity-rare { color: var(--color-rarity-rare); }
|
|
||||||
.entity-entry-name.rarity-very-rare { color: var(--color-rarity-very-rare); }
|
|
||||||
.entity-entry-name.rarity-legendary { color: var(--color-rarity-legendary); }
|
|
||||||
.entity-entry-image {
|
.entity-entry-image {
|
||||||
flex: 0 0 30px; width: 30px; height: 30px; box-sizing: border-box;
|
flex: 0 0 30px; width: 30px; height: 30px; box-sizing: border-box;
|
||||||
display: grid; place-items: center; overflow: hidden;
|
display: grid; place-items: center; overflow: hidden;
|
||||||
|
|||||||
@@ -34,11 +34,6 @@ const tabs = [
|
|||||||
];
|
];
|
||||||
const activeTab = ref('abilities');
|
const activeTab = ref('abilities');
|
||||||
|
|
||||||
// Les pestanyes pengen del marc de la finestra, per fora del contingent (vegeu .sheet-tabs). La
|
|
||||||
// finestra es fa més estreta perquè el marge que la centra sigui prou ample per aguantar-les;
|
|
||||||
// per sota de 760px el marc les fa estar a dins i el marge deixa de fer falta.
|
|
||||||
const TAB_RAIL_WIDTH = 150;
|
|
||||||
|
|
||||||
function normalizeActor(actor) {
|
function normalizeActor(actor) {
|
||||||
return {
|
return {
|
||||||
name: actor?.name ?? '',
|
name: actor?.name ?? '',
|
||||||
@@ -49,16 +44,6 @@ function normalizeActor(actor) {
|
|||||||
abilityScores: Object.fromEntries(abilityStats.map(({ key }) => [key, Number(actor?.abilityScores?.[key] ?? 10)])),
|
abilityScores: Object.fromEntries(abilityStats.map(({ key }) => [key, Number(actor?.abilityScores?.[key] ?? 10)])),
|
||||||
armorClass: Number(actor?.armorClass ?? 10),
|
armorClass: Number(actor?.armorClass ?? 10),
|
||||||
speed: Number(actor?.speed ?? 30),
|
speed: Number(actor?.speed ?? 30),
|
||||||
// Les barres sota la imatge: `current` de `max`. Un personatge que encara no en té
|
|
||||||
// rep un dau de cop per nivell, que és el que D&D compta.
|
|
||||||
hitPoints: {
|
|
||||||
current: Number(actor?.hitPoints?.current ?? actor?.hitPoints?.max ?? 10),
|
|
||||||
max: Number(actor?.hitPoints?.max ?? actor?.hitPoints?.current ?? 10)
|
|
||||||
},
|
|
||||||
hitDice: {
|
|
||||||
current: Number(actor?.hitDice?.current ?? actor?.level ?? 1),
|
|
||||||
max: Number(actor?.hitDice?.max ?? actor?.level ?? 1)
|
|
||||||
},
|
|
||||||
proficiencies: actor?.proficiencies ?? '',
|
proficiencies: actor?.proficiencies ?? '',
|
||||||
inventory: (actor?.inventory ?? []).map((item) => ({
|
inventory: (actor?.inventory ?? []).map((item) => ({
|
||||||
name: item.name ?? '', quantity: Number(item.quantity ?? 1), weight: Number(item.weight ?? 0)
|
name: item.name ?? '', quantity: Number(item.quantity ?? 1), weight: Number(item.weight ?? 0)
|
||||||
@@ -75,11 +60,8 @@ original.value = normalizeActor(props.data.actor);
|
|||||||
onMounted(() => {
|
onMounted(() => {
|
||||||
Top(wrapper);
|
Top(wrapper);
|
||||||
SetupHandle(id, handle);
|
SetupHandle(id, handle);
|
||||||
// Les pestanyes pengen del marc per fora del cos: com que la finestra es centra, el marge que
|
|
||||||
// li queda a la dreta és la meitat del que li sobra, i cal reservar-nos el doble.
|
|
||||||
const railRoom = window.innerWidth > 760 ? 2 * TAB_RAIL_WIDTH : 0;
|
|
||||||
SetSize(id, {
|
SetSize(id, {
|
||||||
width: Math.max(320, Math.min(900, window.innerWidth - 24 - railRoom)),
|
width: Math.max(320, Math.min(900, window.innerWidth - 24)),
|
||||||
height: Math.max(360, Math.min(700, window.innerHeight - 32))
|
height: Math.max(360, Math.min(700, window.innerHeight - 32))
|
||||||
});
|
});
|
||||||
ResetPosition(id, 'center');
|
ResetPosition(id, 'center');
|
||||||
@@ -97,15 +79,6 @@ onMounted(() => emitter.on('campaign-entry-updated', handleActorSync));
|
|||||||
onBeforeUnmount(() => emitter.off('campaign-entry-updated', handleActorSync));
|
onBeforeUnmount(() => emitter.off('campaign-entry-updated', handleActorSync));
|
||||||
|
|
||||||
const proficiencyBonus = computed(() => Math.ceil(form.value.level / 4) + 1);
|
const proficiencyBonus = computed(() => Math.ceil(form.value.level / 4) + 1);
|
||||||
// La iniciativa és el modificador de DESTÀ, que és el que D&D compta quan el personatge no
|
|
||||||
// porta cap do extra que l'augmenti.
|
|
||||||
const initiativeBonus = computed(() => abilityModifier(form.value.abilityScores.dex));
|
|
||||||
// Quina part del màxim representa la barra; buida (màxim 0) o per sobre, tot tallat.
|
|
||||||
function barPercent(current, max) {
|
|
||||||
return max > 0 ? Math.min(100, Math.max(0, ((Number(current) || 0) / max) * 100)) : 0;
|
|
||||||
}
|
|
||||||
const hitPointsPercent = computed(() => barPercent(form.value.hitPoints.current, form.value.hitPoints.max));
|
|
||||||
const hitDicePercent = computed(() => barPercent(form.value.hitDice.current, form.value.hitDice.max));
|
|
||||||
const carryingCapacity = computed(() => form.value.abilityScores.str * 15);
|
const carryingCapacity = computed(() => form.value.abilityScores.str * 15);
|
||||||
const carriedWeight = computed(() => form.value.inventory.reduce((total, item) => total + (Number(item.quantity) || 0) * (Number(item.weight) || 0), 0));
|
const carriedWeight = computed(() => form.value.inventory.reduce((total, item) => total + (Number(item.quantity) || 0) * (Number(item.weight) || 0), 0));
|
||||||
const carryPercent = computed(() => Math.min(100, carryingCapacity.value ? (carriedWeight.value / carryingCapacity.value) * 100 : 0));
|
const carryPercent = computed(() => Math.min(100, carryingCapacity.value ? (carriedWeight.value / carryingCapacity.value) * 100 : 0));
|
||||||
@@ -206,21 +179,6 @@ async function saveSheet() {
|
|||||||
<template>
|
<template>
|
||||||
<div class="window-wrapper sheet-window" :id="'window-wrapper-' + id" ref="wrapper">
|
<div class="window-wrapper sheet-window" :id="'window-wrapper-' + id" ref="wrapper">
|
||||||
<WindowHandle :window="id" ref="handle" />
|
<WindowHandle :window="id" ref="handle" />
|
||||||
|
|
||||||
<!-- Pestilletes del marc de la finestra: pengen del cantó dret, per fora del
|
|
||||||
contingent, i no s'enrolen quan la fitxa desfila. -->
|
|
||||||
<nav class="sheet-tabs" role="tablist" aria-orientation="vertical">
|
|
||||||
<button
|
|
||||||
v-for="tab in tabs"
|
|
||||||
:key="tab.key"
|
|
||||||
class="sheet-tab"
|
|
||||||
:class="{ active: activeTab === tab.key }"
|
|
||||||
type="button"
|
|
||||||
role="tab"
|
|
||||||
:aria-selected="activeTab === tab.key"
|
|
||||||
@click="activeTab = tab.key"
|
|
||||||
>{{ $t(tab.label) }}</button>
|
|
||||||
</nav>
|
|
||||||
<div class="sheet-body">
|
<div class="sheet-body">
|
||||||
<header class="sheet-hero">
|
<header class="sheet-hero">
|
||||||
<div class="character-mark" aria-hidden="true">{{ form.name.slice(0, 1).toUpperCase() }}</div>
|
<div class="character-mark" aria-hidden="true">{{ form.name.slice(0, 1).toUpperCase() }}</div>
|
||||||
@@ -259,143 +217,124 @@ async function saveSheet() {
|
|||||||
|
|
||||||
<div v-if="error" class="sheet-error">{{ error }}</div>
|
<div v-if="error" class="sheet-error">{{ error }}</div>
|
||||||
|
|
||||||
<main v-show="activeTab === 'abilities'" class="sheet-grid">
|
<div class="sheet-layout">
|
||||||
<div class="character-column">
|
<div class="sheet-content">
|
||||||
<div v-if="form.image || editing" class="sheet-portrait" :class="{ empty: !form.image }">
|
<main v-show="activeTab === 'abilities'" class="sheet-grid">
|
||||||
<img v-if="form.image" :src="imageUrl" :alt="$t('campaigns.character-sheet.photo')">
|
<div v-if="form.image || editing" class="sheet-portrait" :class="{ empty: !form.image }">
|
||||||
<button v-if="editing && !form.image" class="portrait-upload" type="button" :disabled="uploadingPhoto" @click="pickPhoto">
|
<img v-if="form.image" :src="imageUrl" :alt="$t('campaigns.character-sheet.photo')">
|
||||||
{{ uploadingPhoto ? $t('campaigns.character-sheet.uploading-photo') : $t('campaigns.character-sheet.upload-photo') }}
|
<button v-if="editing && !form.image" class="portrait-upload" type="button" :disabled="uploadingPhoto" @click="pickPhoto">
|
||||||
</button>
|
{{ uploadingPhoto ? $t('campaigns.character-sheet.uploading-photo') : $t('campaigns.character-sheet.upload-photo') }}
|
||||||
<div v-if="editing && form.image" class="portrait-controls">
|
|
||||||
<button type="button" :disabled="uploadingPhoto" @click="pickPhoto">
|
|
||||||
{{ uploadingPhoto ? $t('campaigns.character-sheet.uploading-photo') : $t('campaigns.character-sheet.change-photo') }}
|
|
||||||
</button>
|
</button>
|
||||||
<button type="button" :disabled="uploadingPhoto" :aria-label="$t('campaigns.character-sheet.remove-photo')" @click="removePhoto">×</button>
|
<div v-if="editing && form.image" class="portrait-controls">
|
||||||
|
<button type="button" :disabled="uploadingPhoto" @click="pickPhoto">
|
||||||
|
{{ uploadingPhoto ? $t('campaigns.character-sheet.uploading-photo') : $t('campaigns.character-sheet.change-photo') }}
|
||||||
|
</button>
|
||||||
|
<button type="button" :disabled="uploadingPhoto" :aria-label="$t('campaigns.character-sheet.remove-photo')" @click="removePhoto">×</button>
|
||||||
|
</div>
|
||||||
|
<input ref="photoInput" class="photo-input" type="file" accept="image/*" @change="onPhotoSelected">
|
||||||
</div>
|
</div>
|
||||||
<input ref="photoInput" class="photo-input" type="file" accept="image/*" @change="onPhotoSelected">
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<!-- El que es mira primer: classe d'armadura, velocitat i els bonificadors
|
<section class="sheet-panel abilities-panel">
|
||||||
que acompanyen els cops, tot just sota la imatge. -->
|
<h2>{{ $t('campaigns.character-sheet.ability-scores') }}</h2>
|
||||||
<section class="sheet-panel vitals-panel">
|
<div class="ability-grid">
|
||||||
<div class="vital-stats">
|
<div v-for="stat in abilityStats" :key="stat.key" class="ability-card">
|
||||||
<div class="vital-stat">
|
<span class="ability-label">{{ stat.label }}</span>
|
||||||
<span>{{ $t('campaigns.character-sheet.armor-class') }}</span>
|
<input v-if="editing" v-model.number="form.abilityScores[stat.key]" type="number" min="1" max="30" :aria-label="stat.label">
|
||||||
<input v-if="editing" v-model.number="form.armorClass" type="number" min="0" :aria-label="$t('campaigns.character-sheet.armor-class')">
|
<strong v-else class="ability-score">{{ form.abilityScores[stat.key] }}</strong>
|
||||||
<strong v-else>{{ form.armorClass }}</strong>
|
<span class="ability-modifier">{{ abilityModifier(form.abilityScores[stat.key]) }}</span>
|
||||||
|
</div>
|
||||||
</div>
|
</div>
|
||||||
<div class="vital-stat">
|
<div class="proficiency-badge">
|
||||||
<span>{{ $t('campaigns.character-sheet.speed') }}</span>
|
|
||||||
<label v-if="editing" class="number-with-unit"><input v-model.number="form.speed" type="number" min="0" :aria-label="$t('campaigns.character-sheet.speed')"><small>ft</small></label>
|
|
||||||
<strong v-else>{{ form.speed }} <small>ft</small></strong>
|
|
||||||
</div>
|
|
||||||
<div class="vital-stat">
|
|
||||||
<span>{{ $t('campaigns.character-sheet.proficiency-bonus') }}</span>
|
<span>{{ $t('campaigns.character-sheet.proficiency-bonus') }}</span>
|
||||||
<strong>+{{ proficiencyBonus }}</strong>
|
<strong>+{{ proficiencyBonus }}</strong>
|
||||||
</div>
|
</div>
|
||||||
<div class="vital-stat">
|
</section>
|
||||||
<span>{{ $t('campaigns.character-sheet.initiative') }}</span>
|
|
||||||
<strong>{{ initiativeBonus }}</strong>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
|
|
||||||
<div class="vital-bar hit-points-bar">
|
<section class="sheet-panel combat-panel">
|
||||||
<div class="vital-bar-head">
|
<h2>{{ $t('campaigns.character-sheet.combat') }}</h2>
|
||||||
<span>{{ $t('campaigns.character-sheet.hit-points') }}</span>
|
<div class="combat-stats">
|
||||||
<strong v-if="!editing">{{ form.hitPoints.current }} / {{ form.hitPoints.max }}</strong>
|
<div class="combat-stat">
|
||||||
<label v-else class="vital-bar-inputs">
|
<span>{{ $t('campaigns.character-sheet.armor-class') }}</span>
|
||||||
<input v-model.number="form.hitPoints.current" type="number" min="0" :aria-label="$t('campaigns.character-sheet.hit-points')">
|
<input v-if="editing" v-model.number="form.armorClass" type="number" min="0">
|
||||||
<span>/</span>
|
<strong v-else>{{ form.armorClass }}</strong>
|
||||||
<input v-model.number="form.hitPoints.max" type="number" min="0" :aria-label="$t('campaigns.character-sheet.max-hit-points')">
|
</div>
|
||||||
</label>
|
<div class="combat-stat">
|
||||||
|
<span>{{ $t('campaigns.character-sheet.speed') }}</span>
|
||||||
|
<label v-if="editing" class="number-with-unit"><input v-model.number="form.speed" type="number" min="0"><small>ft</small></label>
|
||||||
|
<strong v-else>{{ form.speed }} <small>ft</small></strong>
|
||||||
|
</div>
|
||||||
</div>
|
</div>
|
||||||
<div class="vital-bar-track"><div class="vital-bar-fill" :style="{ width: `${hitPointsPercent}%` }" /></div>
|
<h3>{{ $t('campaigns.character-sheet.proficiencies') }}</h3>
|
||||||
</div>
|
<textarea v-if="editing" v-model="form.proficiencies" rows="5" :placeholder="$t('campaigns.character-sheet.proficiencies-placeholder')" />
|
||||||
|
<p v-else class="sheet-copy">{{ form.proficiencies || $t('campaigns.character-sheet.empty-proficiencies') }}</p>
|
||||||
|
</section>
|
||||||
|
</main>
|
||||||
|
|
||||||
<div class="vital-bar hit-dice-bar">
|
<main v-show="activeTab === 'inventory'" class="sheet-tab-body">
|
||||||
<div class="vital-bar-head">
|
<section class="sheet-panel inventory-panel">
|
||||||
<span>{{ $t('campaigns.character-sheet.hit-dice') }}</span>
|
<div class="panel-title-row">
|
||||||
<strong v-if="!editing">{{ form.hitDice.current }} / {{ form.hitDice.max }}</strong>
|
<h2>{{ $t('campaigns.character-sheet.inventory') }}</h2>
|
||||||
<label v-else class="vital-bar-inputs">
|
<button v-if="editing" class="sheet-button secondary compact" type="button" @click="addInventoryItem">{{ $t('campaigns.character-sheet.add-item') }}</button>
|
||||||
<input v-model.number="form.hitDice.current" type="number" min="0" :aria-label="$t('campaigns.character-sheet.hit-dice')">
|
|
||||||
<span>/</span>
|
|
||||||
<input v-model.number="form.hitDice.max" type="number" min="0" :aria-label="$t('campaigns.character-sheet.max-hit-dice')">
|
|
||||||
</label>
|
|
||||||
</div>
|
</div>
|
||||||
<div class="vital-bar-track"><div class="vital-bar-fill" :style="{ width: `${hitDicePercent}%` }" /></div>
|
<div class="weight-summary">
|
||||||
</div>
|
<span>{{ $t('campaigns.character-sheet.carried-weight') }}</span>
|
||||||
</section>
|
<strong>{{ carriedWeight.toFixed(1) }} / {{ carryingCapacity }} lb</strong>
|
||||||
|
</div>
|
||||||
|
<div class="weight-track"><div class="weight-fill" :style="{ width: `${carryPercent}%` }" /></div>
|
||||||
|
<div class="inventory-table-wrap">
|
||||||
|
<table class="inventory-table">
|
||||||
|
<thead><tr>
|
||||||
|
<th>{{ $t('campaigns.character-sheet.item-name') }}</th>
|
||||||
|
<th>{{ $t('campaigns.character-sheet.quantity') }}</th>
|
||||||
|
<th>{{ $t('campaigns.character-sheet.weight-each') }}</th>
|
||||||
|
<th>{{ $t('campaigns.character-sheet.total-weight') }}</th>
|
||||||
|
<th v-if="editing"><span class="sr-only">{{ $t('campaigns.character-sheet.actions') }}</span></th>
|
||||||
|
</tr></thead>
|
||||||
|
<tbody>
|
||||||
|
<tr v-for="(item, index) in form.inventory" :key="index">
|
||||||
|
<td><input v-if="editing" v-model="item.name" :aria-label="$t('campaigns.character-sheet.item-name')"><span v-else>{{ item.name }}</span></td>
|
||||||
|
<td><input v-if="editing" v-model.number="item.quantity" type="number" min="1" :aria-label="$t('campaigns.character-sheet.quantity')"><span v-else>{{ item.quantity }}</span></td>
|
||||||
|
<td><input v-if="editing" v-model.number="item.weight" type="number" min="0" step="0.1" :aria-label="$t('campaigns.character-sheet.weight-each')"><span v-else>{{ Number(item.weight).toFixed(1) }} lb</span></td>
|
||||||
|
<td>{{ ((Number(item.quantity) || 0) * (Number(item.weight) || 0)).toFixed(1) }} lb</td>
|
||||||
|
<td v-if="editing"><button class="remove-item" type="button" @click="removeInventoryItem(index)">×</button></td>
|
||||||
|
</tr>
|
||||||
|
<tr v-if="form.inventory.length === 0"><td :colspan="editing ? 5 : 4" class="empty-inventory">{{ $t('campaigns.character-sheet.empty-inventory') }}</td></tr>
|
||||||
|
</tbody>
|
||||||
|
</table>
|
||||||
|
</div>
|
||||||
|
</section>
|
||||||
|
</main>
|
||||||
|
|
||||||
|
<main v-show="activeTab === 'traits'" class="sheet-tab-body">
|
||||||
|
<section class="sheet-panel traits-panel">
|
||||||
|
<h2>{{ $t('campaigns.character-sheet.traits') }}</h2>
|
||||||
|
<textarea v-if="editing" v-model="form.traits" rows="12" :placeholder="$t('campaigns.character-sheet.traits-placeholder')" />
|
||||||
|
<p v-else class="sheet-copy">{{ form.traits || $t('campaigns.character-sheet.empty-traits') }}</p>
|
||||||
|
</section>
|
||||||
|
</main>
|
||||||
|
|
||||||
|
<main v-show="activeTab === 'spells'" class="sheet-tab-body">
|
||||||
|
<section class="sheet-panel spells-panel">
|
||||||
|
<h2>{{ $t('campaigns.character-sheet.spells') }}</h2>
|
||||||
|
<textarea v-if="editing" v-model="form.spells" rows="12" :placeholder="$t('campaigns.character-sheet.spells-placeholder')" />
|
||||||
|
<p v-else class="sheet-copy">{{ form.spells || $t('campaigns.character-sheet.empty-spells') }}</p>
|
||||||
|
</section>
|
||||||
|
</main>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
<section class="sheet-panel abilities-panel">
|
<nav class="sheet-tabs" role="tablist" aria-orientation="vertical">
|
||||||
<h2>{{ $t('campaigns.character-sheet.ability-scores') }}</h2>
|
<button
|
||||||
<div class="ability-grid">
|
v-for="tab in tabs"
|
||||||
<div v-for="stat in abilityStats" :key="stat.key" class="ability-card">
|
:key="tab.key"
|
||||||
<span class="ability-label">{{ stat.label }}</span>
|
class="sheet-tab"
|
||||||
<input v-if="editing" v-model.number="form.abilityScores[stat.key]" type="number" min="1" max="30" :aria-label="stat.label">
|
:class="{ active: activeTab === tab.key }"
|
||||||
<strong v-else class="ability-score">{{ form.abilityScores[stat.key] }}</strong>
|
type="button"
|
||||||
<span class="ability-modifier">{{ abilityModifier(form.abilityScores[stat.key]) }}</span>
|
role="tab"
|
||||||
</div>
|
:aria-selected="activeTab === tab.key"
|
||||||
</div>
|
@click="activeTab = tab.key"
|
||||||
</section>
|
>{{ $t(tab.label) }}</button>
|
||||||
|
</nav>
|
||||||
<section class="sheet-panel proficiencies-panel">
|
</div>
|
||||||
<h2>{{ $t('campaigns.character-sheet.proficiencies') }}</h2>
|
|
||||||
<textarea v-if="editing" v-model="form.proficiencies" rows="7" :placeholder="$t('campaigns.character-sheet.proficiencies-placeholder')" />
|
|
||||||
<p v-else class="sheet-copy">{{ form.proficiencies || $t('campaigns.character-sheet.empty-proficiencies') }}</p>
|
|
||||||
</section>
|
|
||||||
</main>
|
|
||||||
|
|
||||||
<main v-show="activeTab === 'inventory'" class="sheet-tab-body">
|
|
||||||
<section class="sheet-panel inventory-panel">
|
|
||||||
<div class="panel-title-row">
|
|
||||||
<h2>{{ $t('campaigns.character-sheet.inventory') }}</h2>
|
|
||||||
<button v-if="editing" class="sheet-button secondary compact" type="button" @click="addInventoryItem">{{ $t('campaigns.character-sheet.add-item') }}</button>
|
|
||||||
</div>
|
|
||||||
<div class="weight-summary">
|
|
||||||
<span>{{ $t('campaigns.character-sheet.carried-weight') }}</span>
|
|
||||||
<strong>{{ carriedWeight.toFixed(1) }} / {{ carryingCapacity }} lb</strong>
|
|
||||||
</div>
|
|
||||||
<div class="weight-track"><div class="weight-fill" :style="{ width: `${carryPercent}%` }" /></div>
|
|
||||||
<div class="inventory-table-wrap">
|
|
||||||
<table class="inventory-table">
|
|
||||||
<thead><tr>
|
|
||||||
<th>{{ $t('campaigns.character-sheet.item-name') }}</th>
|
|
||||||
<th>{{ $t('campaigns.character-sheet.quantity') }}</th>
|
|
||||||
<th>{{ $t('campaigns.character-sheet.weight-each') }}</th>
|
|
||||||
<th>{{ $t('campaigns.character-sheet.total-weight') }}</th>
|
|
||||||
<th v-if="editing"><span class="sr-only">{{ $t('campaigns.character-sheet.actions') }}</span></th>
|
|
||||||
</tr></thead>
|
|
||||||
<tbody>
|
|
||||||
<tr v-for="(item, index) in form.inventory" :key="index">
|
|
||||||
<td><input v-if="editing" v-model="item.name" :aria-label="$t('campaigns.character-sheet.item-name')"><span v-else>{{ item.name }}</span></td>
|
|
||||||
<td><input v-if="editing" v-model.number="item.quantity" type="number" min="1" :aria-label="$t('campaigns.character-sheet.quantity')"><span v-else>{{ item.quantity }}</span></td>
|
|
||||||
<td><input v-if="editing" v-model.number="item.weight" type="number" min="0" step="0.1" :aria-label="$t('campaigns.character-sheet.weight-each')"><span v-else>{{ Number(item.weight).toFixed(1) }} lb</span></td>
|
|
||||||
<td>{{ ((Number(item.quantity) || 0) * (Number(item.weight) || 0)).toFixed(1) }} lb</td>
|
|
||||||
<td v-if="editing"><button class="remove-item" type="button" @click="removeInventoryItem(index)">×</button></td>
|
|
||||||
</tr>
|
|
||||||
<tr v-if="form.inventory.length === 0"><td :colspan="editing ? 5 : 4" class="empty-inventory">{{ $t('campaigns.character-sheet.empty-inventory') }}</td></tr>
|
|
||||||
</tbody>
|
|
||||||
</table>
|
|
||||||
</div>
|
|
||||||
</section>
|
|
||||||
</main>
|
|
||||||
|
|
||||||
<main v-show="activeTab === 'traits'" class="sheet-tab-body">
|
|
||||||
<section class="sheet-panel traits-panel">
|
|
||||||
<h2>{{ $t('campaigns.character-sheet.traits') }}</h2>
|
|
||||||
<textarea v-if="editing" v-model="form.traits" rows="12" :placeholder="$t('campaigns.character-sheet.traits-placeholder')" />
|
|
||||||
<p v-else class="sheet-copy">{{ form.traits || $t('campaigns.character-sheet.empty-traits') }}</p>
|
|
||||||
</section>
|
|
||||||
</main>
|
|
||||||
|
|
||||||
<main v-show="activeTab === 'spells'" class="sheet-tab-body">
|
|
||||||
<section class="sheet-panel spells-panel">
|
|
||||||
<h2>{{ $t('campaigns.character-sheet.spells') }}</h2>
|
|
||||||
<textarea v-if="editing" v-model="form.spells" rows="12" :placeholder="$t('campaigns.character-sheet.spells-placeholder')" />
|
|
||||||
<p v-else class="sheet-copy">{{ form.spells || $t('campaigns.character-sheet.empty-spells') }}</p>
|
|
||||||
</section>
|
|
||||||
</main>
|
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
</template>
|
</template>
|
||||||
@@ -420,15 +359,15 @@ async function saveSheet() {
|
|||||||
.sheet-button:disabled { opacity: .55; cursor: wait; }
|
.sheet-button:disabled { opacity: .55; cursor: wait; }
|
||||||
.sheet-button.compact { padding: 5px 9px; font-size: 12px; }
|
.sheet-button.compact { padding: 5px 9px; font-size: 12px; }
|
||||||
.sheet-grid { display: grid; grid-template-columns: minmax(200px, 34%) minmax(0, 1fr) minmax(0, 1fr); grid-template-rows: auto auto; gap: 11px; align-items: start; }
|
.sheet-grid { display: grid; grid-template-columns: minmax(200px, 34%) minmax(0, 1fr) minmax(0, 1fr); grid-template-rows: auto auto; gap: 11px; align-items: start; }
|
||||||
|
.sheet-layout { display: flex; align-items: flex-start; gap: 10px; }
|
||||||
|
.sheet-content { flex: 1 1 auto; min-width: 0; }
|
||||||
.sheet-tab-body { display: block; }
|
.sheet-tab-body { display: block; }
|
||||||
/* Pestilletes del marc: arrencen del cantó dret de la finestra, per fora del cos, i queden
|
.sheet-tabs { flex: 0 0 auto; display: flex; flex-direction: column; gap: 6px; position: sticky; top: 0; align-self: flex-start; }
|
||||||
fora del contingent que desfila. Per sota de 760px no hi ha lloc fora (vegeu a sota). */
|
|
||||||
.sheet-tabs { position: absolute; left: 100%; top: 34px; display: flex; flex-direction: column; align-items: flex-start; gap: 5px; padding-top: 6px; }
|
|
||||||
.sheet-tab {
|
.sheet-tab {
|
||||||
text-align: left;
|
text-align: left;
|
||||||
padding: 9px 14px 9px 11px;
|
padding: 9px 14px 9px 11px;
|
||||||
border: 1px solid var(--color-border);
|
border: 1px solid var(--color-border);
|
||||||
border-left: 0;
|
border-left-width: 3px;
|
||||||
border-radius: 0 9px 9px 0;
|
border-radius: 0 9px 9px 0;
|
||||||
background: var(--color-background-soft);
|
background: var(--color-background-soft);
|
||||||
color: var(--color-text);
|
color: var(--color-text);
|
||||||
@@ -439,11 +378,11 @@ async function saveSheet() {
|
|||||||
transition: background .15s ease, border-color .15s ease, color .15s ease;
|
transition: background .15s ease, border-color .15s ease, color .15s ease;
|
||||||
}
|
}
|
||||||
.sheet-tab:hover { background: var(--color-button-hover); }
|
.sheet-tab:hover { background: var(--color-button-hover); }
|
||||||
.sheet-tab.active { background: var(--color-background-light); color: var(--color-link); border-color: var(--color-link); box-shadow: 0 3px 12px var(--color-window-shadow); }
|
.sheet-tab.active { background: var(--color-background-light); color: var(--color-link); border-left-color: var(--color-link); box-shadow: 0 3px 12px var(--color-window-shadow); }
|
||||||
.sheet-panel { min-width: 0; padding: 13px; border: 1px solid var(--color-border); border-radius: 10px; background: var(--color-background-light); box-shadow: 0 3px 12px var(--color-window-shadow); }
|
.sheet-panel { min-width: 0; padding: 13px; border: 1px solid var(--color-border); border-radius: 10px; background: var(--color-background-light); box-shadow: 0 3px 12px var(--color-window-shadow); }
|
||||||
.sheet-panel h2 { margin: 0 0 12px; padding-bottom: 7px; border-bottom: 1px solid var(--color-border); font: 17px MrEavesRemake; letter-spacing: .03em; }
|
.sheet-panel h2 { margin: 0 0 12px; padding-bottom: 7px; border-bottom: 1px solid var(--color-border); font: 17px MrEavesRemake; letter-spacing: .03em; }
|
||||||
.sheet-panel h3 { margin: 13px 0 7px; font: 14px MrEavesRemake; }
|
.sheet-panel h3 { margin: 13px 0 7px; font: 14px MrEavesRemake; }
|
||||||
.sheet-portrait { position: relative; overflow: hidden; border: 1px solid var(--color-border); border-radius: 10px; background: var(--color-background-soft); }
|
.sheet-portrait { grid-column: 1; grid-row: 1 / -1; position: relative; overflow: hidden; border: 1px solid var(--color-border); border-radius: 10px; background: var(--color-background-soft); }
|
||||||
.sheet-portrait.empty { display: grid; place-items: center; min-height: 220px; border-style: dashed; }
|
.sheet-portrait.empty { display: grid; place-items: center; min-height: 220px; border-style: dashed; }
|
||||||
.sheet-portrait img { display: block; width: 100%; height: auto; }
|
.sheet-portrait img { display: block; width: 100%; height: auto; }
|
||||||
.portrait-upload { border: 0; padding: 8px 10px; background: transparent; color: var(--color-link); font-size: 12px; cursor: pointer; }
|
.portrait-upload { border: 0; padding: 8px 10px; background: transparent; color: var(--color-link); font-size: 12px; cursor: pointer; }
|
||||||
@@ -453,34 +392,21 @@ async function saveSheet() {
|
|||||||
.portrait-controls button:hover { background: var(--color-button-hover); }
|
.portrait-controls button:hover { background: var(--color-button-hover); }
|
||||||
.portrait-controls button:disabled { opacity: .55; cursor: wait; }
|
.portrait-controls button:disabled { opacity: .55; cursor: wait; }
|
||||||
.photo-input { display: none; }
|
.photo-input { display: none; }
|
||||||
/* La columna de la fitxa: la imatge dalt i, just a sota, el que es consulta d'anada i
|
|
||||||
tornada — classe d'armadura, velocitat, bonificadors i les barres de cops. */
|
|
||||||
.character-column { grid-column: 1; grid-row: 1 / -1; display: flex; flex-direction: column; gap: 11px; min-width: 0; }
|
|
||||||
.abilities-panel { grid-column: 2 / -1; grid-row: 1; }
|
.abilities-panel { grid-column: 2 / -1; grid-row: 1; }
|
||||||
.proficiencies-panel { grid-column: 2 / -1; grid-row: 2; }
|
.combat-panel { grid-column: 2 / -1; grid-row: 2; }
|
||||||
.ability-grid { display: grid; grid-template-columns: repeat(6, minmax(0, 1fr)); gap: 7px; }
|
.ability-grid { display: grid; grid-template-columns: repeat(6, minmax(0, 1fr)); gap: 7px; }
|
||||||
.ability-card { min-height: 83px; padding: 8px 5px; display: flex; flex-direction: column; align-items: center; justify-content: center; gap: 3px; border: 1px solid var(--color-border); border-radius: 8px; background: var(--color-background-soft); }
|
.ability-card { min-height: 83px; padding: 8px 5px; display: flex; flex-direction: column; align-items: center; justify-content: center; gap: 3px; border: 1px solid var(--color-border); border-radius: 8px; background: var(--color-background-soft); }
|
||||||
.ability-label { font-size: 11px; font-weight: 700; letter-spacing: .08em; opacity: .75; }
|
.ability-label { font-size: 11px; font-weight: 700; letter-spacing: .08em; opacity: .75; }
|
||||||
.ability-score { font: 25px MrEavesRemake; }
|
.ability-score { font: 25px MrEavesRemake; }
|
||||||
.ability-modifier { min-width: 33px; text-align: center; padding: 2px 5px; border-radius: 999px; background: var(--color-background); font-size: 12px; }
|
.ability-modifier { min-width: 33px; text-align: center; padding: 2px 5px; border-radius: 999px; background: var(--color-background); font-size: 12px; }
|
||||||
.ability-card input { width: 55px; text-align: center; font-size: 21px; }
|
.ability-card input { width: 55px; text-align: center; font-size: 21px; }
|
||||||
.vitals-panel { display: flex; flex-direction: column; gap: 11px; }
|
.proficiency-badge { display: flex; justify-content: space-between; align-items: center; margin-top: 9px; padding: 8px; border-radius: 8px; background: var(--color-background-soft); font-size: 12px; }
|
||||||
.vital-stats { display: grid; grid-template-columns: 1fr 1fr; gap: 7px; }
|
.proficiency-badge strong { font-size: 15px; color: var(--color-link); }
|
||||||
.vital-stat { min-height: 68px; display: flex; flex-direction: column; align-items: center; justify-content: center; gap: 4px; padding: 6px 4px; border: 1px solid var(--color-border); border-radius: 8px; background: var(--color-background-soft); text-align: center; }
|
.combat-stats { display: grid; grid-template-columns: 1fr 1fr; gap: 8px; }
|
||||||
.vital-stat > span { font-size: 10px; text-transform: uppercase; letter-spacing: .05em; opacity: .72; }
|
.combat-stat { min-height: 72px; display: flex; flex-direction: column; align-items: center; justify-content: center; gap: 5px; border: 1px solid var(--color-border); border-radius: 8px; background: var(--color-background-soft); }
|
||||||
.vital-stat > strong { font: 25px MrEavesRemake; }
|
.combat-stat > span { font-size: 11px; text-transform: uppercase; letter-spacing: .05em; opacity: .72; }
|
||||||
.vital-stat small { font-size: 11px; opacity: .7; }
|
.combat-stat > strong { font: 25px MrEavesRemake; }
|
||||||
.vital-stat input { width: 57px; text-align: center; }
|
.combat-stat small { font-size: 11px; opacity: .7; }
|
||||||
/* Les dues barres: punts de cop i daus de cop, plenes fins on arriben. */
|
|
||||||
.vital-bar-head { display: flex; justify-content: space-between; align-items: center; gap: 8px; }
|
|
||||||
.vital-bar-head > span { font-size: 10px; text-transform: uppercase; letter-spacing: .05em; opacity: .72; }
|
|
||||||
.vital-bar-head > strong { font: 15px MrEavesRemake; white-space: nowrap; }
|
|
||||||
.vital-bar-inputs { display: flex; align-items: center; gap: 4px; }
|
|
||||||
.vital-bar-inputs input { width: 52px; text-align: center; }
|
|
||||||
.vital-bar-track { height: 8px; margin-top: 5px; overflow: hidden; border-radius: 999px; background: var(--color-background); }
|
|
||||||
.vital-bar-fill { height: 100%; border-radius: inherit; transition: width .2s ease; }
|
|
||||||
.hit-points-bar .vital-bar-fill { background: var(--color-red); }
|
|
||||||
.hit-dice-bar .vital-bar-fill { background: var(--color-link); }
|
|
||||||
.number-with-unit { display: flex; align-items: center; gap: 4px; }
|
.number-with-unit { display: flex; align-items: center; gap: 4px; }
|
||||||
.number-with-unit input { width: 57px; }
|
.number-with-unit input { width: 57px; }
|
||||||
.sheet-copy { min-height: 74px; margin: 0; white-space: pre-wrap; overflow-wrap: anywhere; font-size: 13px; line-height: 1.45; opacity: .85; }
|
.sheet-copy { min-height: 74px; margin: 0; white-space: pre-wrap; overflow-wrap: anywhere; font-size: 13px; line-height: 1.45; opacity: .85; }
|
||||||
@@ -508,16 +434,16 @@ textarea { resize: vertical; width: 100%; min-height: 88px; font-size: 12px; }
|
|||||||
.sr-only { position: absolute; width: 1px; height: 1px; padding: 0; margin: -1px; overflow: hidden; clip: rect(0, 0, 0, 0); white-space: nowrap; border: 0; }
|
.sr-only { position: absolute; width: 1px; height: 1px; padding: 0; margin: -1px; overflow: hidden; clip: rect(0, 0, 0, 0); white-space: nowrap; border: 0; }
|
||||||
@media (max-width: 760px) {
|
@media (max-width: 760px) {
|
||||||
.sheet-grid { grid-template-columns: 1fr; grid-template-rows: none; }
|
.sheet-grid { grid-template-columns: 1fr; grid-template-rows: none; }
|
||||||
.character-column, .abilities-panel, .proficiencies-panel { grid-column: 1 / -1; grid-row: auto; }
|
.sheet-portrait, .abilities-panel, .combat-panel { grid-column: 1 / -1; grid-row: auto; }
|
||||||
/* El cantó dret no dona prou per penjar-hi les pestanyes: llavors es queden al marc, per
|
|
||||||
dins, en una filera sota la barra de la finestra. */
|
|
||||||
.sheet-tabs { position: static; align-self: stretch; flex-direction: row; flex-wrap: wrap; gap: 4px; padding: 6px 8px 0; }
|
|
||||||
.sheet-tab { flex: 1 1 auto; text-align: center; border-left: 1px solid var(--color-border); border-radius: 8px 8px 0 0; }
|
|
||||||
}
|
}
|
||||||
@media (max-width: 520px) {
|
@media (max-width: 520px) {
|
||||||
.sheet-body { padding: 10px; }
|
.sheet-body { padding: 10px; }
|
||||||
.sheet-hero { align-items: flex-start; flex-wrap: wrap; }
|
.sheet-hero { align-items: flex-start; flex-wrap: wrap; }
|
||||||
.sheet-actions { margin-left: auto; }
|
.sheet-actions { margin-left: auto; }
|
||||||
.ability-grid { grid-template-columns: repeat(3, minmax(0, 1fr)); }
|
.ability-grid { grid-template-columns: repeat(3, minmax(0, 1fr)); }
|
||||||
|
.sheet-layout { flex-direction: column; }
|
||||||
|
.sheet-tabs { flex-direction: row; flex-wrap: wrap; order: -1; }
|
||||||
|
.sheet-tab { flex: 1 1 auto; text-align: center; border-radius: 7px; border-left-width: 1px; border-top-width: 3px; }
|
||||||
|
.sheet-tab.active { border-left-color: var(--color-border); border-top-color: var(--color-link); }
|
||||||
}
|
}
|
||||||
</style>
|
</style>
|
||||||
|
|||||||
@@ -20,13 +20,13 @@ function initialForm() {
|
|||||||
if (!editing) {
|
if (!editing) {
|
||||||
return {
|
return {
|
||||||
name: '', type: 'character', species: '', className: '', level: '', background: '', challengeRating: '',
|
name: '', type: 'character', species: '', className: '', level: '', background: '', challengeRating: '',
|
||||||
category: 'adventuring-gear', rarity: 'common', weight: '', properties: '', description: ''
|
category: 'adventuring-gear', rarity: 'common', quantity: 1, weight: '', properties: '', description: ''
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
return {
|
return {
|
||||||
name: editing.name ?? '', type: 'character', species: '', className: '', level: '', background: '', challengeRating: '',
|
name: editing.name ?? '', type: 'character', species: '', className: '', level: '', background: '', challengeRating: '',
|
||||||
category: editing.category ?? 'adventuring-gear', rarity: editing.rarity ?? 'common',
|
category: editing.category ?? 'adventuring-gear', rarity: editing.rarity ?? 'common',
|
||||||
weight: editing.weight ?? '', properties: editing.properties ?? '',
|
quantity: editing.quantity ?? 1, weight: editing.weight ?? '', properties: editing.properties ?? '',
|
||||||
description: editing.description ?? ''
|
description: editing.description ?? ''
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
@@ -49,7 +49,7 @@ async function saveEntry() {
|
|||||||
? { name: form.value.name.trim(), campaign: data.campaign }
|
? { name: form.value.name.trim(), campaign: data.campaign }
|
||||||
: { name: form.value.name.trim(), ...(editing ? { id: editing._id } : { campaign: data.campaign }) };
|
: { name: form.value.name.trim(), ...(editing ? { id: editing._id } : { campaign: data.campaign }) };
|
||||||
if (!isActor) {
|
if (!isActor) {
|
||||||
for (const field of ['category', 'rarity', 'weight', 'properties', 'description']) {
|
for (const field of ['category', 'rarity', 'quantity', 'weight', 'properties', 'description']) {
|
||||||
payload[field] = form.value[field];
|
payload[field] = form.value[field];
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -105,6 +105,10 @@ async function saveEntry() {
|
|||||||
<option value="artifact">{{ $t('campaigns.item.rarities.artifact') }}</option>
|
<option value="artifact">{{ $t('campaigns.item.rarities.artifact') }}</option>
|
||||||
</select>
|
</select>
|
||||||
</label>
|
</label>
|
||||||
|
<label class="form-field">
|
||||||
|
<span>{{ $t('campaigns.item.quantity') }}</span>
|
||||||
|
<input v-model.number="form.quantity" type="number" min="1" required>
|
||||||
|
</label>
|
||||||
<label class="form-field">
|
<label class="form-field">
|
||||||
<span>{{ $t('campaigns.item.weight') }}</span>
|
<span>{{ $t('campaigns.item.weight') }}</span>
|
||||||
<input v-model="form.weight" type="number" min="0" step="0.1">
|
<input v-model="form.weight" type="number" min="0" step="0.1">
|
||||||
|
|||||||
@@ -24,6 +24,7 @@ function normalizeItem(item) {
|
|||||||
name: item?.name ?? '',
|
name: item?.name ?? '',
|
||||||
category: item?.category ?? 'adventuring-gear',
|
category: item?.category ?? 'adventuring-gear',
|
||||||
rarity: item?.rarity ?? 'common',
|
rarity: item?.rarity ?? 'common',
|
||||||
|
quantity: Number(item?.quantity ?? 1),
|
||||||
weight: item?.weight ?? '',
|
weight: item?.weight ?? '',
|
||||||
properties: item?.properties ?? '',
|
properties: item?.properties ?? '',
|
||||||
description: item?.description ?? '',
|
description: item?.description ?? '',
|
||||||
@@ -147,9 +148,11 @@ async function removeIcon() {
|
|||||||
<button v-if="form.image" class="sheet-button secondary" type="button" :disabled="applyingIcon" :aria-label="$t('campaigns.item.sheet.remove-icon')" @click="removeIcon">×</button>
|
<button v-if="form.image" class="sheet-button secondary" type="button" :disabled="applyingIcon" :aria-label="$t('campaigns.item.sheet.remove-icon')" @click="removeIcon">×</button>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
<!-- Quantity is the actor inventory's business (Syndria98/dragonroll#63); the item
|
|
||||||
sheet only states what the item itself is. -->
|
|
||||||
<dl class="item-facts">
|
<dl class="item-facts">
|
||||||
|
<div class="item-fact">
|
||||||
|
<dt>{{ $t('campaigns.item.quantity') }}</dt>
|
||||||
|
<dd>{{ form.quantity }}</dd>
|
||||||
|
</div>
|
||||||
<div v-if="form.weight !== '' && form.weight !== undefined" class="item-fact">
|
<div v-if="form.weight !== '' && form.weight !== undefined" class="item-fact">
|
||||||
<dt>{{ $t('campaigns.item.weight') }}</dt>
|
<dt>{{ $t('campaigns.item.weight') }}</dt>
|
||||||
<dd>{{ Number(form.weight).toFixed(1) }} lb</dd>
|
<dd>{{ Number(form.weight).toFixed(1) }} lb</dd>
|
||||||
|
|||||||
@@ -65,8 +65,8 @@
|
|||||||
},
|
},
|
||||||
"item": {
|
"item": {
|
||||||
"new": "Objecte nou", "edit": "Edita l'objecte", "foundry-sync-note": "Els canvis en aquest objecte també s'apliquen al món del Foundry vinculat.",
|
"new": "Objecte nou", "edit": "Edita l'objecte", "foundry-sync-note": "Els canvis en aquest objecte també s'apliquen al món del Foundry vinculat.",
|
||||||
"category": "Categoria", "rarity": "Raresa",
|
"category": "Categoria", "rarity": "Raresa", "quantity": "Quantitat",
|
||||||
"weight": "Pes (lb)", "properties": "Propietats", "properties-placeholder": "Per exemple, versàtil, subtil",
|
"quantity-short": "Quant.", "weight": "Pes (lb)", "properties": "Propietats", "properties-placeholder": "Per exemple, versàtil, subtil",
|
||||||
"sheet": {
|
"sheet": {
|
||||||
"icon": "Icona de l'objecte", "choose-icon": "Tria la teva pròpia icona", "change-icon": "Canvia la icona",
|
"icon": "Icona de l'objecte", "choose-icon": "Tria la teva pròpia icona", "change-icon": "Canvia la icona",
|
||||||
"uploading": "Pujant...", "upload-error": "No s'ha pogut pujar aquesta icona.",
|
"uploading": "Pujant...", "upload-error": "No s'ha pogut pujar aquesta icona.",
|
||||||
@@ -113,8 +113,7 @@
|
|||||||
"tabs": { "abilities": "Característiques", "inventory": "Inventari", "traits": "Trets", "spells": "Conjurs" },
|
"tabs": { "abilities": "Característiques", "inventory": "Inventari", "traits": "Trets", "spells": "Conjurs" },
|
||||||
"level": "Nivell", "species": "Espècie", "unset-species": "Espècie sense definir", "edit": "Edita la fitxa", "cancel": "Cancel·la",
|
"level": "Nivell", "species": "Espècie", "unset-species": "Espècie sense definir", "edit": "Edita la fitxa", "cancel": "Cancel·la",
|
||||||
"saving": "Desant...", "save": "Desa la fitxa", "save-error": "No s'ha pogut desar aquesta fitxa de personatge.", "photo": "Foto", "upload-photo": "Pujar foto", "change-photo": "Canviar foto", "remove-photo": "Treure foto", "uploading-photo": "Pujant...", "photo-error": "No s'ha pogut pujar aquesta foto.", "ability-scores": "Característiques", "proficiency-bonus": "Bonificador de competència",
|
"saving": "Desant...", "save": "Desa la fitxa", "save-error": "No s'ha pogut desar aquesta fitxa de personatge.", "photo": "Foto", "upload-photo": "Pujar foto", "change-photo": "Canviar foto", "remove-photo": "Treure foto", "uploading-photo": "Pujant...", "photo-error": "No s'ha pogut pujar aquesta foto.", "ability-scores": "Característiques", "proficiency-bonus": "Bonificador de competència",
|
||||||
"combat": "Combat", "armor-class": "Classe d'armadura", "speed": "Velocitat", "initiative": "Iniciativa",
|
"combat": "Combat", "armor-class": "Classe d'armadura", "speed": "Velocitat", "proficiencies": "Competències",
|
||||||
"hit-points": "Punts de cop", "max-hit-points": "Punts de cop màxims", "hit-dice": "Daus de cop", "max-hit-dice": "Daus de cop màxims", "proficiencies": "Competències",
|
|
||||||
"proficiencies-placeholder": "Afegeix salvacions, habilitats, armadures, armes, eines i idiomes...", "empty-proficiencies": "No hi ha competències afegides.",
|
"proficiencies-placeholder": "Afegeix salvacions, habilitats, armadures, armes, eines i idiomes...", "empty-proficiencies": "No hi ha competències afegides.",
|
||||||
"traits": "Trets", "traits-placeholder": "Afegeix trets, capacitats i altres detalls...", "empty-traits": "No hi ha trets afegits.",
|
"traits": "Trets", "traits-placeholder": "Afegeix trets, capacitats i altres detalls...", "empty-traits": "No hi ha trets afegits.",
|
||||||
"spells": "Conjurs", "spells-placeholder": "Escriu els conjurs, un per línia...", "empty-spells": "No hi ha conjurs afegits.",
|
"spells": "Conjurs", "spells-placeholder": "Escriu els conjurs, un per línia...", "empty-spells": "No hi ha conjurs afegits.",
|
||||||
|
|||||||
@@ -69,8 +69,8 @@
|
|||||||
},
|
},
|
||||||
"item": {
|
"item": {
|
||||||
"new": "New item", "edit": "Edit item", "foundry-sync-note": "Changes to this item are also applied in the linked Foundry world.",
|
"new": "New item", "edit": "Edit item", "foundry-sync-note": "Changes to this item are also applied in the linked Foundry world.",
|
||||||
"category": "Category", "rarity": "Rarity",
|
"category": "Category", "rarity": "Rarity", "quantity": "Quantity",
|
||||||
"weight": "Weight (lb)", "properties": "Properties", "properties-placeholder": "For example, versatile, finesse",
|
"quantity-short": "Qty", "weight": "Weight (lb)", "properties": "Properties", "properties-placeholder": "For example, versatile, finesse",
|
||||||
"sheet": {
|
"sheet": {
|
||||||
"icon": "Item icon", "choose-icon": "Choose your own icon", "change-icon": "Change icon",
|
"icon": "Item icon", "choose-icon": "Choose your own icon", "change-icon": "Change icon",
|
||||||
"uploading": "Uploading...", "upload-error": "Unable to upload this icon.",
|
"uploading": "Uploading...", "upload-error": "Unable to upload this icon.",
|
||||||
@@ -119,8 +119,7 @@
|
|||||||
"saving": "Saving...", "save": "Save sheet", "save-error": "Unable to save this character sheet.",
|
"saving": "Saving...", "save": "Save sheet", "save-error": "Unable to save this character sheet.",
|
||||||
"photo": "Photo", "upload-photo": "Upload photo", "change-photo": "Change photo", "remove-photo": "Remove photo",
|
"photo": "Photo", "upload-photo": "Upload photo", "change-photo": "Change photo", "remove-photo": "Remove photo",
|
||||||
"uploading-photo": "Uploading...", "photo-error": "Unable to upload this photo.", "ability-scores": "Ability Scores", "proficiency-bonus": "Proficiency Bonus",
|
"uploading-photo": "Uploading...", "photo-error": "Unable to upload this photo.", "ability-scores": "Ability Scores", "proficiency-bonus": "Proficiency Bonus",
|
||||||
"combat": "Combat", "armor-class": "Armor Class", "speed": "Speed", "initiative": "Initiative",
|
"combat": "Combat", "armor-class": "Armor Class", "speed": "Speed", "proficiencies": "Proficiencies",
|
||||||
"hit-points": "Hit Points", "max-hit-points": "Maximum hit points", "hit-dice": "Hit Dice", "max-hit-dice": "Maximum hit dice", "proficiencies": "Proficiencies",
|
|
||||||
"proficiencies-placeholder": "Add saving throws, skills, armor, weapons, tools, and languages...", "empty-proficiencies": "No proficiencies added.",
|
"proficiencies-placeholder": "Add saving throws, skills, armor, weapons, tools, and languages...", "empty-proficiencies": "No proficiencies added.",
|
||||||
"traits": "Traits", "traits-placeholder": "Add features, traits, and other character details...", "empty-traits": "No traits added.",
|
"traits": "Traits", "traits-placeholder": "Add features, traits, and other character details...", "empty-traits": "No traits added.",
|
||||||
"spells": "Spells", "spells-placeholder": "List spells, one per line...", "empty-spells": "No spells added.",
|
"spells": "Spells", "spells-placeholder": "List spells, one per line...", "empty-spells": "No spells added.",
|
||||||
|
|||||||
@@ -65,8 +65,8 @@
|
|||||||
},
|
},
|
||||||
"item": {
|
"item": {
|
||||||
"new": "Nuevo objeto", "edit": "Editar objeto", "foundry-sync-note": "Los cambios en este objeto también se aplican al mundo de Foundry vinculado.",
|
"new": "Nuevo objeto", "edit": "Editar objeto", "foundry-sync-note": "Los cambios en este objeto también se aplican al mundo de Foundry vinculado.",
|
||||||
"category": "Categoría", "rarity": "Rareza",
|
"category": "Categoría", "rarity": "Rareza", "quantity": "Cantidad",
|
||||||
"weight": "Peso (lb)", "properties": "Propiedades", "properties-placeholder": "Por ejemplo, versátil, sutil",
|
"quantity-short": "Cant.", "weight": "Peso (lb)", "properties": "Propiedades", "properties-placeholder": "Por ejemplo, versátil, sutil",
|
||||||
"sheet": {
|
"sheet": {
|
||||||
"icon": "Icono del objeto", "choose-icon": "Elegir tu propio icono", "change-icon": "Cambiar icono",
|
"icon": "Icono del objeto", "choose-icon": "Elegir tu propio icono", "change-icon": "Cambiar icono",
|
||||||
"uploading": "Subiendo...", "upload-error": "No se pudo subir este icono.",
|
"uploading": "Subiendo...", "upload-error": "No se pudo subir este icono.",
|
||||||
@@ -113,8 +113,7 @@
|
|||||||
"tabs": { "abilities": "Características", "inventory": "Inventario", "traits": "Rasgos", "spells": "Conjuros" },
|
"tabs": { "abilities": "Características", "inventory": "Inventario", "traits": "Rasgos", "spells": "Conjuros" },
|
||||||
"level": "Nivel", "species": "Especie", "unset-species": "Especie sin definir", "edit": "Editar hoja", "cancel": "Cancelar",
|
"level": "Nivel", "species": "Especie", "unset-species": "Especie sin definir", "edit": "Editar hoja", "cancel": "Cancelar",
|
||||||
"saving": "Guardando...", "save": "Guardar hoja", "save-error": "No se pudo guardar esta hoja de personaje.", "photo": "Foto", "upload-photo": "Subir foto", "change-photo": "Cambiar foto", "remove-photo": "Quitar foto", "uploading-photo": "Subiendo...", "photo-error": "No se pudo subir esta foto.", "ability-scores": "Características", "proficiency-bonus": "Bonificador por competencia",
|
"saving": "Guardando...", "save": "Guardar hoja", "save-error": "No se pudo guardar esta hoja de personaje.", "photo": "Foto", "upload-photo": "Subir foto", "change-photo": "Cambiar foto", "remove-photo": "Quitar foto", "uploading-photo": "Subiendo...", "photo-error": "No se pudo subir esta foto.", "ability-scores": "Características", "proficiency-bonus": "Bonificador por competencia",
|
||||||
"combat": "Combate", "armor-class": "Clase de armadura", "speed": "Velocidad", "initiative": "Iniciativa",
|
"combat": "Combate", "armor-class": "Clase de armadura", "speed": "Velocidad", "proficiencies": "Competencias",
|
||||||
"hit-points": "Puntos de golpe", "max-hit-points": "Puntos de golpe máximos", "hit-dice": "Dados de golpe", "max-hit-dice": "Dados de golpe máximos", "proficiencies": "Competencias",
|
|
||||||
"proficiencies-placeholder": "Añade salvaciones, habilidades, armaduras, armas, herramientas e idiomas...", "empty-proficiencies": "No hay competencias añadidas.",
|
"proficiencies-placeholder": "Añade salvaciones, habilidades, armaduras, armas, herramientas e idiomas...", "empty-proficiencies": "No hay competencias añadidas.",
|
||||||
"traits": "Rasgos", "traits-placeholder": "Añade rasgos, capacidades y otros detalles...", "empty-traits": "No hay rasgos añadidos.",
|
"traits": "Rasgos", "traits-placeholder": "Añade rasgos, capacidades y otros detalles...", "empty-traits": "No hay rasgos añadidos.",
|
||||||
"spells": "Conjuros", "spells-placeholder": "Escribe los conjuros, uno por línea...", "empty-spells": "No hay conjuros añadidos.",
|
"spells": "Conjuros", "spells-placeholder": "Escribe los conjuros, uno por línea...", "empty-spells": "No hay conjuros añadidos.",
|
||||||
|
|||||||
@@ -1,167 +0,0 @@
|
|||||||
// Tests for Syndria98/dragonroll#64, the second round of modifications to the character sheet:
|
|
||||||
// * the tab rail hangs off the border of the window instead of standing inside the sheet body,
|
|
||||||
// * the armor class, the speed, the proficiency bonus and the initiative bonus stand under the
|
|
||||||
// portrait, together with the hit points and the hit dice, both drawn as bars.
|
|
||||||
//
|
|
||||||
// The window is a `.vue` file and the repository root installs no dependencies for it, so its
|
|
||||||
// template and styles are read out of the source the way tests/character-sheet-tabs.test.js reads
|
|
||||||
// them. The plain functions the sheet and the route work out their numbers with are lifted out of
|
|
||||||
// those sources and called, the way tests/map-viewer.test.js runs a service it cannot import.
|
|
||||||
//
|
|
||||||
// Run with `npm test` from the repository root, or `node --test tests/`.
|
|
||||||
|
|
||||||
const { test } = require("node:test");
|
|
||||||
const assert = require("node:assert/strict");
|
|
||||||
const fs = require("node:fs");
|
|
||||||
const path = require("node:path");
|
|
||||||
|
|
||||||
const read = (...parts) => fs.readFileSync(path.join(__dirname, "..", ...parts), "utf8");
|
|
||||||
|
|
||||||
const sheetSource = read("frontend", "app", "components", "windows", "CharacterSheetWindow.vue");
|
|
||||||
const script = /<script setup>([\s\S]*?)<\/script>/.exec(sheetSource)?.[1] ?? "";
|
|
||||||
const template = /<template>([\s\S]*)<\/template>/.exec(sheetSource)?.[1] ?? "";
|
|
||||||
const actorModelSource = read("backend", "src", "models", "Actor.js");
|
|
||||||
const actorRouteSource = read("backend", "src", "routes", "actor.js");
|
|
||||||
|
|
||||||
// `fromSource` hands back one top-level declaration as a value. Imports and refs are module scope
|
|
||||||
// the test does not have, so the few names a declaration reads are passed in as arguments. The
|
|
||||||
// declaration runs in this realm, so the objects it builds compare with the ones the test builds.
|
|
||||||
function fromSource(source, pattern, locals = {}) {
|
|
||||||
const declaration = pattern.exec(source)?.[0];
|
|
||||||
assert.ok(declaration, `expected ${pattern} in the source`);
|
|
||||||
const name = /(?:const|function)\s+(\w+)/.exec(declaration)[1];
|
|
||||||
return new Function(...Object.keys(locals), `${declaration}\n;return ${name};`)(...Object.values(locals));
|
|
||||||
}
|
|
||||||
|
|
||||||
const abilityStats = fromSource(script, /const abilityStats = \[[\s\S]*?\];/);
|
|
||||||
const normalizeActor = fromSource(script, /function normalizeActor\(actor\) \{[\s\S]*?\n\}/, { abilityStats });
|
|
||||||
const barPercent = fromSource(script, /function barPercent\(current, max\) \{[\s\S]*?\n\}/);
|
|
||||||
const barPool = fromSource(actorRouteSource, /function barPool\(existing, value\) \{[\s\S]*?\n\}/);
|
|
||||||
|
|
||||||
// The column that opens the abilities tab: the portrait with everything under it.
|
|
||||||
function portraitColumn() {
|
|
||||||
const start = template.indexOf('<div class="character-column">');
|
|
||||||
const end = template.indexOf('<section class="sheet-panel abilities-panel">');
|
|
||||||
assert.ok(start !== -1 && end > start, "expected a character column ahead of the ability scores");
|
|
||||||
return template.slice(start, end);
|
|
||||||
}
|
|
||||||
|
|
||||||
test("the tab rail hangs off the border of the window, outside the sheet body", () => {
|
|
||||||
const rail = /\.sheet-tabs\s*\{[^}]*\}/.exec(sheetSource)?.[0] ?? "";
|
|
||||||
assert.match(rail, /position:\s*absolute/, "the rail is mounted on the window frame");
|
|
||||||
assert.match(rail, /left:\s*100%/, "it starts at the right border and reaches outwards");
|
|
||||||
assert.ok(
|
|
||||||
template.indexOf('<nav class="sheet-tabs"') < template.indexOf('<div class="sheet-body">'),
|
|
||||||
"the rail is a child of the window, ahead of the body it hangs beside"
|
|
||||||
);
|
|
||||||
const body = /\.sheet-body\s*\{[^}]*\}/.exec(sheetSource)?.[0] ?? "";
|
|
||||||
assert.match(body, /overflow:\s*auto/, "the sheet body scrolls on its own, the rail stays put");
|
|
||||||
});
|
|
||||||
|
|
||||||
test("the armor class, the speed and both bonuses stand under the portrait", () => {
|
|
||||||
const column = portraitColumn();
|
|
||||||
assert.ok(column.includes('class="sheet-portrait"'), "the portrait opens the column");
|
|
||||||
assert.ok(column.includes('class="sheet-panel vitals-panel"'), "the readouts follow the image");
|
|
||||||
assert.ok(
|
|
||||||
column.indexOf('class="sheet-portrait"') < column.indexOf("vitals-panel"),
|
|
||||||
"the readouts stand under the image, not above it"
|
|
||||||
);
|
|
||||||
for (const key of ["armor-class", "speed", "proficiency-bonus", "initiative"]) {
|
|
||||||
assert.ok(
|
|
||||||
column.includes(`campaigns.character-sheet.${key}`),
|
|
||||||
`the ${key} belongs under the image`
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Gone from where they were: the combat panel is nothing but proficiencies left over, and the
|
|
||||||
// ability scores panel keeps the six scores only.
|
|
||||||
assert.doesNotMatch(template, /combat-panel/, "the combat panel went with the combat stats");
|
|
||||||
const abilities = template
|
|
||||||
.slice(template.indexOf('<section class="sheet-panel abilities-panel">'))
|
|
||||||
.split("</section>")[0];
|
|
||||||
assert.doesNotMatch(abilities, /proficiency-bonus/, "the proficiency bonus moved down the column");
|
|
||||||
assert.match(abilities, /campaigns\.character-sheet\.ability-scores/);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("the hit points and the hit dice stand as bars under the portrait", () => {
|
|
||||||
const column = portraitColumn();
|
|
||||||
assert.match(column, /class="vital-bar hit-points-bar"/);
|
|
||||||
assert.match(column, /class="vital-bar hit-dice-bar"/);
|
|
||||||
for (const pool of ["hitPoints", "hitDice"]) {
|
|
||||||
assert.match(column, new RegExp(`v-model\\.number="form\\.${pool}\\.current"`), `${pool} is editable`);
|
|
||||||
assert.match(column, new RegExp(`v-model\\.number="form\\.${pool}\\.max"`), `${pool} has a maximum to set`);
|
|
||||||
assert.match(
|
|
||||||
column,
|
|
||||||
new RegExp(`\\{\\{ form\\.${pool}\\.current \\}\\} / \\{\\{ form\\.${pool}\\.max \\}\\}`),
|
|
||||||
`${pool} reads current of max outside of editing`
|
|
||||||
);
|
|
||||||
}
|
|
||||||
// Each bar fills what its own maximum allows, and each is painted its own colour.
|
|
||||||
assert.match(column, /:style="\{ width: `\$\{hitPointsPercent\}%` \}"/);
|
|
||||||
assert.match(column, /:style="\{ width: `\$\{hitDicePercent\}%` \}"/);
|
|
||||||
assert.match(sheetSource, /\.hit-points-bar \.vital-bar-fill\s*\{[^}]*var\(--color-red\)/);
|
|
||||||
assert.match(sheetSource, /\.hit-dice-bar \.vital-bar-fill\s*\{[^}]*var\(--color-link\)/);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("a bar fills what its maximum allows, no more and no less", () => {
|
|
||||||
assert.equal(barPercent(5, 10), 50);
|
|
||||||
assert.equal(barPercent(12, 10), 100, "healed past the maximum does not overflow the track");
|
|
||||||
assert.equal(barPercent(-3, 10), 0, "nothing left stands empty");
|
|
||||||
assert.equal(barPercent(4, 0), 0, "a maximum of nothing is no bar either");
|
|
||||||
assert.equal(barPercent("", 10), 0, "an input cleared mid-edit is read as nothing");
|
|
||||||
});
|
|
||||||
|
|
||||||
test("the initiative bonus is the modifier of dexterity", () => {
|
|
||||||
assert.match(
|
|
||||||
script,
|
|
||||||
/const initiativeBonus = computed\(\(\) => abilityModifier\(form\.value\.abilityScores\.dex\)\)/,
|
|
||||||
"D&D counts initiative as the dexterity modifier while the character carries no extra bonus"
|
|
||||||
);
|
|
||||||
const abilityModifier = fromSource(script, /function abilityModifier\(score\) \{[\s\S]*?\n\}/);
|
|
||||||
assert.equal(abilityModifier(16), "+3");
|
|
||||||
assert.equal(abilityModifier(10), "+0", "the sheet writes a flat modifier with its sign, as the ability cards do");
|
|
||||||
assert.equal(abilityModifier(9), "-1");
|
|
||||||
});
|
|
||||||
|
|
||||||
test("an actor carries its pools, and one without them starts on its level", () => {
|
|
||||||
assert.deepEqual(normalizeActor({ level: 3 }).hitPoints, { current: 10, max: 10 });
|
|
||||||
assert.deepEqual(normalizeActor({ level: 3 }).hitDice, { current: 3, max: 3 }, "one die per level");
|
|
||||||
const wounded = normalizeActor({
|
|
||||||
level: 5,
|
|
||||||
hitPoints: { current: 4, max: 44 },
|
|
||||||
hitDice: { current: 2, max: 5 }
|
|
||||||
});
|
|
||||||
assert.deepEqual(wounded.hitPoints, { current: 4, max: 44 });
|
|
||||||
assert.deepEqual(wounded.hitDice, { current: 2, max: 5 });
|
|
||||||
});
|
|
||||||
|
|
||||||
test("the Actor model stores both pools as current of a maximum", () => {
|
|
||||||
for (const pool of ["hitPoints", "hitDice"]) {
|
|
||||||
assert.match(
|
|
||||||
actorModelSource,
|
|
||||||
new RegExp(`${pool}:\\s*\\{\\s*current:\\s*\\{\\s*type:\\s*Number[^}]*\\},\\s*max:\\s*\\{\\s*type:\\s*Number[^}]*\\}`),
|
|
||||||
`${pool} holds a current and a maximum`
|
|
||||||
);
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
test("the actor update takes both pools and never lets one pass its maximum", () => {
|
|
||||||
assert.match(actorRouteSource, /const \{[^}]*hitPoints[^}]*hitDice[^}]*\} = req\.body;/, "the update reads them off the body");
|
|
||||||
assert.match(actorRouteSource, /if \(hitPoints !== undefined\) actor\.hitPoints = barPool\(actor\.hitPoints, hitPoints\)/);
|
|
||||||
assert.match(actorRouteSource, /if \(hitDice !== undefined\) actor\.hitDice = barPool\(actor\.hitDice, hitDice\)/);
|
|
||||||
|
|
||||||
assert.deepEqual(barPool({ current: 5, max: 20 }, { current: 8, max: 30 }), { current: 8, max: 30 });
|
|
||||||
assert.deepEqual(barPool({ current: 5, max: 20 }, { current: 40 }), { current: 20, max: 20 }, "a current over its maximum stops at the maximum");
|
|
||||||
assert.deepEqual(barPool({ current: 5, max: 20 }, { max: 4 }), { current: 4, max: 4 }, "a maximum lowered below the current pulls it down");
|
|
||||||
assert.deepEqual(barPool({ current: 5, max: 20 }, { current: 12 }), { current: 12, max: 20 }, "half a pair keeps the half it did not send");
|
|
||||||
assert.deepEqual(barPool({ current: 5, max: 20 }, { current: -2, max: 20 }), { current: 0, max: 20 });
|
|
||||||
});
|
|
||||||
|
|
||||||
test("every locale names the readouts that moved under the portrait", () => {
|
|
||||||
for (const locale of ["en", "es", "ca"]) {
|
|
||||||
const sheet = JSON.parse(read("frontend", "i18n", "locales", locale, "campaigns.json"))["character-sheet"];
|
|
||||||
for (const key of ["initiative", "hit-points", "max-hit-points", "hit-dice", "max-hit-dice"]) {
|
|
||||||
assert.ok(sheet[key], `${locale} is missing campaigns.character-sheet.${key}`);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
});
|
|
||||||
@@ -37,10 +37,9 @@ test("the tabs sit on the right as a vertical bookmark rail", () => {
|
|||||||
assert.match(template, /v-for="tab in tabs"[\s\S]*?:aria-selected="activeTab === tab\.key"/);
|
assert.match(template, /v-for="tab in tabs"[\s\S]*?:aria-selected="activeTab === tab\.key"/);
|
||||||
const rail = /\.sheet-tabs\s*\{[^}]*\}/.exec(sheetSource)?.[0] ?? "";
|
const rail = /\.sheet-tabs\s*\{[^}]*\}/.exec(sheetSource)?.[0] ?? "";
|
||||||
assert.match(rail, /flex-direction:\s*column/, "the bookmarks stack down the right edge");
|
assert.match(rail, /flex-direction:\s*column/, "the bookmarks stack down the right edge");
|
||||||
// #64 moved the rail out of the content: it hangs off the window border itself, so it is not
|
// content column and rail sit side by side, the rail hugging the right
|
||||||
// swept along when the sheet scrolls (see tests/character-sheet-portrait-column.test.js).
|
assert.match(sheetSource, /\.sheet-layout\s*\{[^}]*display:\s*flex[^}]*\}/, "content and rail share a row");
|
||||||
assert.match(rail, /position:\s*absolute/, "the rail is mounted on the window frame");
|
assert.match(sheetSource, /\.sheet-content\s*\{[^}]*flex:\s*1[^}]*\}/, "the content takes the room, the rail stays slim");
|
||||||
assert.match(rail, /left:\s*100%/, "the rail stands outside the window's right border");
|
|
||||||
});
|
});
|
||||||
|
|
||||||
// Each tab shows only its own panels; the rest are hidden with v-show so an in-progress edit is
|
// Each tab shows only its own panels; the rest are hidden with v-show so an in-progress edit is
|
||||||
@@ -55,7 +54,7 @@ test("every tab shows only its own content and hides the others", () => {
|
|||||||
const abilities = tabBody("abilities");
|
const abilities = tabBody("abilities");
|
||||||
assert.match(abilities, /class="sheet-portrait"/, "the portrait stays with ability scores");
|
assert.match(abilities, /class="sheet-portrait"/, "the portrait stays with ability scores");
|
||||||
assert.match(abilities, /class="sheet-panel abilities-panel"/);
|
assert.match(abilities, /class="sheet-panel abilities-panel"/);
|
||||||
assert.match(abilities, /class="sheet-panel proficiencies-panel"/, "the proficiencies ride with the ability scores");
|
assert.match(abilities, /class="sheet-panel combat-panel"/, "combat rides with the ability scores");
|
||||||
for (const other of ["inventory-panel", "traits-panel", "spells-panel"]) {
|
for (const other of ["inventory-panel", "traits-panel", "spells-panel"]) {
|
||||||
assert.doesNotMatch(abilities, new RegExp(other));
|
assert.doesNotMatch(abilities, new RegExp(other));
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -57,7 +57,7 @@ function matches(document, filter = {}) {
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
function fakeModel(table, seed = [], campaignId) {
|
function fakeModel(table, seed = []) {
|
||||||
const rows = [];
|
const rows = [];
|
||||||
let counter = 0;
|
let counter = 0;
|
||||||
|
|
||||||
@@ -76,9 +76,7 @@ function fakeModel(table, seed = [], campaignId) {
|
|||||||
Object.defineProperty(Document.prototype, "id", { get() { return this._id; } });
|
Object.defineProperty(Document.prototype, "id", { get() { return this._id; } });
|
||||||
|
|
||||||
for (const data of seed) {
|
for (const data of seed) {
|
||||||
// A seeded row belongs to the campaign the requests are made against unless the
|
const row = new Document({ [table === "folder" ? "target" : "name"]: undefined, ...data });
|
||||||
// seed says otherwise: the routes scope every lookup by campaign.
|
|
||||||
const row = new Document({ campaign: campaignId, [table === "folder" ? "target" : "name"]: undefined, ...data });
|
|
||||||
row.isNew = false;
|
row.isNew = false;
|
||||||
rows.push(row);
|
rows.push(row);
|
||||||
}
|
}
|
||||||
@@ -299,76 +297,6 @@ test("an item the world moved out of a folder follows it to the root", async ()
|
|||||||
assert.equal(sync.models["../models/Item"].rows[0].folder, null);
|
assert.equal(sync.models["../models/Item"].rows[0].folder, null);
|
||||||
});
|
});
|
||||||
|
|
||||||
// --- Only the world's item directory is listed (Syndria98/dragonroll#67) --------------
|
|
||||||
// The campaign's item list equals the world's items tab: gear that only an actor
|
|
||||||
// carries is its inventory (kept on the actor document), not a Dragonroll item.
|
|
||||||
|
|
||||||
test("an actor's gear is kept off the campaign's item list", async () => {
|
|
||||||
const sync = loadSyncRoute();
|
|
||||||
|
|
||||||
await sync.call("POST /sync/snapshot", {
|
|
||||||
worldId: "world-1",
|
|
||||||
items: [worldItem()],
|
|
||||||
// Thalia carries a potion the world's item directory does not hold.
|
|
||||||
actors: [{
|
|
||||||
_id: "actor-1",
|
|
||||||
name: "Thalia",
|
|
||||||
items: [{ _id: "potion-1", name: "Potion of Healing", type: "consumable", system: { quantity: 2 } }],
|
|
||||||
}],
|
|
||||||
});
|
|
||||||
|
|
||||||
const names = sync.models["../models/Item"].rows.map((row) => row.name);
|
|
||||||
assert.deepEqual(names, ["Longsword"], "only the world's item reaches the list, not the actor's potion");
|
|
||||||
});
|
|
||||||
|
|
||||||
test("the campaign's item list is the world's whole item directory", async () => {
|
|
||||||
const sync = loadSyncRoute();
|
|
||||||
|
|
||||||
await sync.call("POST /sync/snapshot", {
|
|
||||||
worldId: "world-1",
|
|
||||||
items: [worldItem(), worldItem({ _id: "item-2", name: "Torch", type: "loot", system: { quantity: 1 } })],
|
|
||||||
actors: [],
|
|
||||||
});
|
|
||||||
|
|
||||||
assert.deepEqual(
|
|
||||||
sync.models["../models/Item"].rows.map((row) => row.name).sort(),
|
|
||||||
["Longsword", "Torch"],
|
|
||||||
);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("an item carried by a character is listed once, as its world entry", async () => {
|
|
||||||
const sync = loadSyncRoute();
|
|
||||||
|
|
||||||
await sync.call("POST /sync/snapshot", {
|
|
||||||
worldId: "world-1",
|
|
||||||
items: [worldItem()],
|
|
||||||
// The same sword, a second copy embedded in an actor under another id.
|
|
||||||
actors: [{ _id: "actor-1", name: "Thalia", items: [worldItem({ _id: "sword-copy" })] }],
|
|
||||||
});
|
|
||||||
|
|
||||||
assert.deepEqual(sync.models["../models/Item"].rows.map((row) => row.name), ["Longsword"]);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("a full snapshot prunes gear that only an actor carried", async () => {
|
|
||||||
const sync = loadSyncRoute({
|
|
||||||
seed: { items: [{ _id: "potion-1", name: "Potion of Healing", foundryItemId: "embedded-1" }] },
|
|
||||||
});
|
|
||||||
|
|
||||||
// The world's item directory is now empty: nothing but a character holds the potion.
|
|
||||||
await sync.call("POST /sync/snapshot", {
|
|
||||||
worldId: "world-1",
|
|
||||||
items: [],
|
|
||||||
actors: [{
|
|
||||||
_id: "actor-1",
|
|
||||||
name: "Thalia",
|
|
||||||
items: [{ _id: "embedded-1", name: "Potion of Healing", type: "consumable", system: { quantity: 2 } }],
|
|
||||||
}],
|
|
||||||
fullSync: true,
|
|
||||||
});
|
|
||||||
|
|
||||||
assert.deepEqual(sync.models["../models/Item"].rows, [], "the actor's own gear no longer stands in the item list");
|
|
||||||
});
|
|
||||||
|
|
||||||
test("a folder coloured in the world is coloured in the campaign", async () => {
|
test("a folder coloured in the world is coloured in the campaign", async () => {
|
||||||
const sync = loadSyncRoute();
|
const sync = loadSyncRoute();
|
||||||
|
|
||||||
@@ -445,12 +373,9 @@ test("every folder listing says which campaign list it belongs to", () => {
|
|||||||
// field existed carry none at all. tests/entry-folders.test.js runs these routes.
|
// field existed carry none at all. tests/entry-folders.test.js runs these routes.
|
||||||
for (const route of ["note.js", "folder.js"]) {
|
for (const route of ["note.js", "folder.js"]) {
|
||||||
const source = read("backend", "src", "routes", route);
|
const source = read("backend", "src", "routes", route);
|
||||||
// The listings that gather a campaign's folders are the ones shown as a section's
|
const listings = source.match(/Folder\.find\(/g) ?? [];
|
||||||
// tree. A walk of one folder's own children (`parentFolder`) is inside a single
|
|
||||||
// list already: folders are only ever nested within their own section.
|
|
||||||
const listings = source.match(/Folder\.find\(\{\s*campaign/g) ?? [];
|
|
||||||
assert.ok(listings.length, `${route} lists folders`);
|
assert.ok(listings.length, `${route} lists folders`);
|
||||||
const filtered = source.match(/Folder\.find\(\{\s*campaign[^{]*Folder\.filterForTarget\((?:'note'|target)\)/g) ?? [];
|
const filtered = source.match(/Folder\.find\(\{[^{]*Folder\.filterForTarget\((?:'note'|target)\)/g) ?? [];
|
||||||
assert.equal(filtered.length, listings.length, `${route} has a folder listing that names no campaign list`);
|
assert.equal(filtered.length, listings.length, `${route} has a folder listing that names no campaign list`);
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
@@ -800,15 +725,13 @@ test("items are grouped under the folder they stand in, nested", () => {
|
|||||||
row.kind, row.kind === "folder" ? row.folder.name : row.item.name, row.depth,
|
row.kind, row.kind === "folder" ? row.folder.name : row.item.name, row.depth,
|
||||||
]);
|
]);
|
||||||
|
|
||||||
// Every folder is followed by what stands in it, one step deeper, and the items that
|
|
||||||
// stand at the root come last (see BuildItemRows).
|
|
||||||
assert.deepEqual(shape, [
|
assert.deepEqual(shape, [
|
||||||
["folder", "Melee Weapons", 0],
|
["folder", "Melee Weapons", 0],
|
||||||
["item", "Longsword", 1],
|
|
||||||
["folder", "Ranged Weapons", 0],
|
["folder", "Ranged Weapons", 0],
|
||||||
["folder", "Powder Weapons", 1],
|
["folder", "Powder Weapons", 1],
|
||||||
["item", "Pistol", 2],
|
["item", "Pistol", 1],
|
||||||
["item", "Torch", 0],
|
["item", "Torch", 0],
|
||||||
|
["item", "Longsword", 1],
|
||||||
]);
|
]);
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -835,9 +758,9 @@ test("an item whose folder is gone, or a folder nested in itself, reads as a roo
|
|||||||
);
|
);
|
||||||
|
|
||||||
const shape = rows.map((row) => [row.kind, row.kind === "folder" ? row.folder.name : row.item.name]);
|
const shape = rows.map((row) => [row.kind, row.kind === "folder" ? row.folder.name : row.item.name]);
|
||||||
assert.ok(shape.some(([kind, name]) => kind === "item" && name === "Torch"), "the item is not lost with the folder that was removed");
|
assert.ok(shape.includes(["item", "Torch"]), "the item is not lost with the folder that was removed");
|
||||||
assert.deepEqual(new Set(shape.filter(([kind]) => kind === "folder").map(([, name]) => name)), new Set(["A", "B"]));
|
assert.deepEqual(new Set(shape.filter(([kind]) => kind === "folder").map(([, name]) => name)), new Set(["A", "B"]));
|
||||||
assert.equal(shape.filter(([kind]) => kind === "folder").length, 2, "a broken tree is walked once, not forever");
|
assert.equal(rows.filter(([kind]) => kind === "folder").length, 2, "a broken tree is walked once, not forever");
|
||||||
});
|
});
|
||||||
|
|
||||||
test("every locale labels the folder row", () => {
|
test("every locale labels the folder row", () => {
|
||||||
|
|||||||
@@ -1,89 +0,0 @@
|
|||||||
// Tests for Syndria98/dragonroll#63: the item rows in the campaign sidebar dropped the text
|
|
||||||
// listing category, rarity and quantity — the rarity colours the text of the entry instead
|
|
||||||
// (common white, uncommon green, rare blue, very rare purple, legendary orange) — and the
|
|
||||||
// quantity left the item surfaces altogether, since it only belongs to an actor's inventory.
|
|
||||||
//
|
|
||||||
// The repository root installs no dependencies, so these read the sources the way
|
|
||||||
// tests/item-entry-display.test.js does — the checks are about the markup and style.
|
|
||||||
//
|
|
||||||
// Run with `npm test` from the repository root, or `node --test tests/`.
|
|
||||||
|
|
||||||
const { test } = require("node:test");
|
|
||||||
const assert = require("node:assert/strict");
|
|
||||||
const fs = require("node:fs");
|
|
||||||
const path = require("node:path");
|
|
||||||
|
|
||||||
const read = (...parts) => fs.readFileSync(path.join(__dirname, "..", ...parts), "utf8");
|
|
||||||
|
|
||||||
const sidebarSource = read("frontend", "app", "components", "partials", "ContentSidebar.vue");
|
|
||||||
const itemWindowSource = read("frontend", "app", "components", "windows", "ItemSheetWindow.vue");
|
|
||||||
const entryFormSource = read("frontend", "app", "components", "windows", "CreateCampaignEntryWindow.vue");
|
|
||||||
const sheetSource = read("frontend", "app", "components", "windows", "CharacterSheetWindow.vue");
|
|
||||||
const colorsSource = read("frontend", "app", "assets", "css", "colors.scss");
|
|
||||||
|
|
||||||
// The block that renders the item rows, as in tests/item-entry-display.test.js.
|
|
||||||
const itemSection =
|
|
||||||
/<template v-else-if="activeSection === 'items'">([\s\S]*?)<\/template>\s*\n\s*<template v-else>/.exec(sidebarSource)?.[1] ?? "";
|
|
||||||
|
|
||||||
const rarities = ["common", "uncommon", "rare", "very-rare", "legendary"];
|
|
||||||
|
|
||||||
// `selector` is inserted verbatim, so escape the `.` of a class combination. Comments are dropped:
|
|
||||||
// they explain a rule, they are not part of it.
|
|
||||||
function ruleFor(selector) {
|
|
||||||
const rule = new RegExp(`\\.${selector}\\s*\\{([^}]*)\\}`).exec(sidebarSource)?.[0];
|
|
||||||
return rule?.replace(/\/\*[\s\S]*?\*\//g, "");
|
|
||||||
}
|
|
||||||
|
|
||||||
test("the item entry no longer lists the category, rarity and quantity as text", () => {
|
|
||||||
assert.ok(itemSection, "expected to find the items section of the sidebar");
|
|
||||||
assert.doesNotMatch(itemSection, /entity-entry-meta/, "the item row must not render a meta line");
|
|
||||||
assert.doesNotMatch(itemSection, /campaigns\.item\.(categories|rarities|quantity)/, "the item row must not render item meta text");
|
|
||||||
assert.doesNotMatch(sidebarSource, /itemSummary/, "the removed summary helper must not be kept around");
|
|
||||||
});
|
|
||||||
|
|
||||||
test("the rarity of an item picks a class for the text of its entry", () => {
|
|
||||||
assert.match(
|
|
||||||
itemSection,
|
|
||||||
/<span class="entity-entry-name" :class="rarityClass\(row\.item\)"/,
|
|
||||||
"the item name must carry the class picked from its rarity"
|
|
||||||
);
|
|
||||||
const helper = /function rarityClass\(item\)\s*\{[\s\S]*?\n\}/.exec(sidebarSource)?.[0] ?? "";
|
|
||||||
assert.ok(helper, "expected a rarityClass helper");
|
|
||||||
for (const rarity of rarities) {
|
|
||||||
assert.ok(helper.includes(`'${rarity}'`), `rarityClass must know about '${rarity}'`);
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
test("each rarity colours the entry text with its own theme colour", () => {
|
|
||||||
for (const rarity of rarities) {
|
|
||||||
const rule = ruleFor(`entity-entry-name\\.rarity-${rarity}`);
|
|
||||||
assert.ok(rule, `expected a colour rule for .entity-entry-name.rarity-${rarity}`);
|
|
||||||
assert.match(rule, new RegExp(`color:\\s*var\\(--color-rarity-${rarity}\\)`));
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
test("both theme maps carry the rarity colours", () => {
|
|
||||||
for (const rarity of rarities) {
|
|
||||||
const declarations = colorsSource.match(new RegExp(`rarity-${rarity}:\\s*#[0-9a-fA-F]{6}`, "g")) || [];
|
|
||||||
assert.equal(declarations.length, 2, `expected rarity-${rarity} in both the dark and the light map`);
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
test("the quantity only shows in an actor's inventory", () => {
|
|
||||||
assert.doesNotMatch(itemWindowSource, /quantity/, "the item window must not list the quantity");
|
|
||||||
assert.doesNotMatch(entryFormSource, /quantity/, "the item create/edit form must not offer the quantity");
|
|
||||||
// the character sheet's inventory table keeps it.
|
|
||||||
assert.match(sheetSource, /campaigns\.character-sheet\.quantity/);
|
|
||||||
assert.match(sheetSource, /\{\{ item\.quantity \}\}/);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("no locale keeps the removed item quantity strings", () => {
|
|
||||||
for (const locale of ["en", "es", "ca"]) {
|
|
||||||
const campaigns = JSON.parse(read("frontend", "i18n", "locales", locale, "campaigns.json"));
|
|
||||||
assert.ok(campaigns.item, `${locale} is missing the campaigns.item block`);
|
|
||||||
assert.equal(campaigns.item.quantity, undefined, `${locale} still has campaigns.item.quantity`);
|
|
||||||
assert.equal(campaigns.item["quantity-short"], undefined, `${locale} still has campaigns.item.quantity-short`);
|
|
||||||
// the character sheet's inventory keeps its own quantity column label
|
|
||||||
assert.ok(campaigns["character-sheet"]?.quantity, `${locale} is missing campaigns.character-sheet.quantity`);
|
|
||||||
}
|
|
||||||
});
|
|
||||||
@@ -66,16 +66,15 @@ test("the item routes accept the icon and upload one", () => {
|
|||||||
test("the item info window is registered and opens on a sidebar click", () => {
|
test("the item info window is registered and opens on a sidebar click", () => {
|
||||||
assert.match(windowDefsSource, /item_sheet:\s*{\s*title:[^}]*ItemSheetWindow\.vue/s);
|
assert.match(windowDefsSource, /item_sheet:\s*{\s*title:[^}]*ItemSheetWindow\.vue/s);
|
||||||
// clicking (or Enter/Space on) an item row opens the window instead of expanding inline.
|
// clicking (or Enter/Space on) an item row opens the window instead of expanding inline.
|
||||||
// The rows come from the item list's folder tree, so the row holds the item.
|
// Since #44 the rows come from the folder tree the world synced, so the row holds the item.
|
||||||
assert.match(sidebarSource, /v-for="row in entryRows\.item\.value"[\s\S]*?@click="openItemSheet\(row\.item\)"/);
|
assert.match(sidebarSource, /v-for="row in itemRows"[\s\S]*?@click="openItemSheet\(row\.item\)"/);
|
||||||
assert.match(sidebarSource, /CreateWindow\(['"]item_sheet['"],\s*\{ item \}\)/);
|
assert.match(sidebarSource, /CreateWindow\(['"]item_sheet['"],\s*\{ item \}\)/);
|
||||||
assert.doesNotMatch(sidebarSource, /toggleEntryDetails/);
|
assert.doesNotMatch(sidebarSource, /toggleEntryDetails/);
|
||||||
});
|
});
|
||||||
|
|
||||||
test("the item window shows the info and offers both icon sources", () => {
|
test("the item window shows the info and offers both icon sources", () => {
|
||||||
// info: name, category, rarity, weight, properties, description — quantity is gone
|
// info: name, category, rarity, quantity, weight, properties, description
|
||||||
// (#63 keeps it for the actors' inventories).
|
for (const key of ["form.name", "form.category", "form.rarity", "form.quantity", "form.weight", "form.properties", "form.description"]) {
|
||||||
for (const key of ["form.name", "form.category", "form.rarity", "form.weight", "form.properties", "form.description"]) {
|
|
||||||
assert.ok(itemWindowSource.includes(key), `expected the window to render ${key}`);
|
assert.ok(itemWindowSource.includes(key), `expected the window to render ${key}`);
|
||||||
}
|
}
|
||||||
// own icon: #65 moved picking one into a window of its own, which uploads through
|
// own icon: #65 moved picking one into a window of its own, which uploads through
|
||||||
|
|||||||
@@ -85,9 +85,6 @@ function loadMapRoutes({ ownsCampaign = true, maps = [], notes = [] } = {}) {
|
|||||||
},
|
},
|
||||||
// The pins do not ask after actors, only the token routes below do.
|
// The pins do not ask after actors, only the token routes below do.
|
||||||
"../models/Actor": { findOne: () => mongooseQuery(null) },
|
"../models/Actor": { findOne: () => mongooseQuery(null) },
|
||||||
// The map list's own folder tree: `/list` reads it and `/update` checks a move
|
|
||||||
// against it, so the pins need the model to answer, never what it answers.
|
|
||||||
"../models/Folder": { find: () => mongooseQuery([]), belongsToSection: async () => true },
|
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -184,12 +181,7 @@ function loadNoteRoutes({ ownsCampaign = true, notes = [], folders = [], deleted
|
|||||||
findById: (id) => mongooseQuery(notes.find((note) => note._id === id) ?? null),
|
findById: (id) => mongooseQuery(notes.find((note) => note._id === id) ?? null),
|
||||||
deleteOne: () => mongooseQuery({ deletedCount }),
|
deleteOne: () => mongooseQuery({ deletedCount }),
|
||||||
},
|
},
|
||||||
"../models/Folder": {
|
"../models/Folder": { find: () => mongooseQuery(folders) },
|
||||||
find: () => mongooseQuery(folders),
|
|
||||||
// models/Folder.js: the note tree is every folder that is not one of the other
|
|
||||||
// campaign lists, whose rows carry no target at all.
|
|
||||||
filterForTarget: (target) => (target === "note" ? { target: { $nin: ["actor", "item", "map"] } } : { target }),
|
|
||||||
},
|
|
||||||
"../models/Map": {
|
"../models/Map": {
|
||||||
// The driver drops the pins of the note from every map holding one; what is worth
|
// The driver drops the pins of the note from every map holding one; what is worth
|
||||||
// keeping here is the filter it is asked to do that with.
|
// keeping here is the filter it is asked to do that with.
|
||||||
|
|||||||
@@ -82,9 +82,6 @@ function loadMapRoutes({ ownsCampaign = true, maps = [], actors = [] } = {}) {
|
|||||||
: null
|
: null
|
||||||
),
|
),
|
||||||
},
|
},
|
||||||
// The map list's own folder tree: `/list` reads it and `/update` checks a move
|
|
||||||
// against it, so the tokens need the model to answer, never what it answers.
|
|
||||||
"../models/Folder": { find: () => mongooseQuery([]), belongsToSection: async () => true },
|
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -191,8 +188,6 @@ function loadActorRoutes({ ownsCampaign = true, actors = [], deletedCount = 1 }
|
|||||||
return { modifiedCount: 1 };
|
return { modifiedCount: 1 };
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
// The actor list's own folder tree, which the delete does not ask after.
|
|
||||||
"../models/Folder": { find: () => mongooseQuery([]), belongsToSection: async () => true },
|
|
||||||
});
|
});
|
||||||
return { api, tokensPulled };
|
return { api, tokensPulled };
|
||||||
}
|
}
|
||||||
@@ -304,14 +299,10 @@ function mapViewerTokenWiringTests() {
|
|||||||
const sidebar = readRepoFile("frontend", "app", "components", "partials", "ContentSidebar.vue");
|
const sidebar = readRepoFile("frontend", "app", "components", "partials", "ContentSidebar.vue");
|
||||||
|
|
||||||
test("an actor row of the sidebar can be dragged out of it", () => {
|
test("an actor row of the sidebar can be dragged out of it", () => {
|
||||||
// The actors' block of the sidebar: since the entry lists got their folders the rows
|
const actorRow = /<div v-for="actor in actors"[^>]*>/.exec(sidebar)?.[0];
|
||||||
// come from that tree, so the actor row holds its actor as `row.item`.
|
|
||||||
const actorSection = /<template v-else-if="activeSection === 'actors'">([\s\S]*?)<\/template>\s*\n\s*<template v-else-if="activeSection === 'items'">/
|
|
||||||
.exec(sidebar)?.[1] ?? "";
|
|
||||||
const actorRow = /<div v-else class="entity-entry"[^>]*>/.exec(actorSection)?.[0];
|
|
||||||
assert.ok(actorRow, "expected the actor rows of the sidebar");
|
assert.ok(actorRow, "expected the actor rows of the sidebar");
|
||||||
assert.match(actorRow, /draggable="true"/);
|
assert.match(actorRow, /draggable="true"/);
|
||||||
assert.match(actorRow, /@dragstart="startActorDrag\(\$event, row\.item\)"/);
|
assert.match(actorRow, /@dragstart="startActorDrag\(\$event, actor\)"/);
|
||||||
assert.match(sidebar, /setData\(ACTOR_DRAG_TYPE, String\(actor\._id\)\)/);
|
assert.match(sidebar, /setData\(ACTOR_DRAG_TYPE, String\(actor\._id\)\)/);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
@@ -1,72 +0,0 @@
|
|||||||
// Tests for Syndria98/dragonroll#71: `pnpm dev` warned, on every frontend build,
|
|
||||||
// "You probably don't mean to use the color value red in interpolation here" from `theme-vars()`
|
|
||||||
// in colors.scss. `red`, `green` and `gray` are also Sass colour keywords, so as unquoted map keys
|
|
||||||
// they were parsed as colour *values* and interpolating one into `--color-#{$name}` warned (and can
|
|
||||||
// emit an invalid name). Quoting those keys keeps them strings; the emitted CSS is unchanged, so
|
|
||||||
// `var(--color-red)` and friends still resolve.
|
|
||||||
//
|
|
||||||
// `sass` is not installed for `npm test`, so this reads colors.scss the way the other tests read
|
|
||||||
// sources: the check is that no map key is left bare when it spells a CSS colour keyword.
|
|
||||||
//
|
|
||||||
// Run with `npm test` from the repository root, or `node --test tests/`.
|
|
||||||
|
|
||||||
const { test } = require("node:test");
|
|
||||||
const assert = require("node:assert/strict");
|
|
||||||
const fs = require("node:fs");
|
|
||||||
const path = require("node:path");
|
|
||||||
|
|
||||||
const read = (...parts) => fs.readFileSync(path.join(__dirname, "..", ...parts), "utf8");
|
|
||||||
|
|
||||||
const colorsSource = read("frontend", "app", "assets", "css", "colors.scss");
|
|
||||||
|
|
||||||
// The CSS named colours. Sass parses any of these (in any case) as a colour value, so a theme or
|
|
||||||
// accent map key spelled like one of them has to be quoted to stay a string.
|
|
||||||
const colorKeywords = new Set(
|
|
||||||
[
|
|
||||||
"aliceblue", "antiquewhite", "aqua", "aquamarine", "azure", "beige", "bisque", "black",
|
|
||||||
"blanchedalmond", "blue", "blueviolet", "brown", "burlywood", "cadetblue", "chartreuse",
|
|
||||||
"chocolate", "coral", "cornflowerblue", "cornsilk", "crimson", "cyan", "darkblue", "darkcyan",
|
|
||||||
"darkgoldenrod", "darkgray", "darkgreen", "darkkhaki", "darkmagenta", "darkolivegreen",
|
|
||||||
"darkorange", "darkorchid", "darkred", "darksalmon", "darkseagreen", "darkslateblue",
|
|
||||||
"darkslategray", "darkturquoise", "darkviolet", "deeppink", "deepskyblue", "dimgray",
|
|
||||||
"dodgerblue", "firebrick", "floralwhite", "forestgreen", "fuchsia", "gainsboro", "ghostwhite",
|
|
||||||
"gold", "goldenrod", "gray", "green", "greenyellow", "honeydew", "hotpink", "indianred",
|
|
||||||
"indigo", "ivory", "khaki", "lavender", "lavenderblush", "lawngreen", "lemonchiffon",
|
|
||||||
"lightblue", "lightcoral", "lightcyan", "lightgoldenrodyellow", "lightgray", "lightgreen",
|
|
||||||
"lightpink", "lightsalmon", "lightseagreen", "lightskyblue", "lightslategray",
|
|
||||||
"lightsteelblue", "lightyellow", "lime", "limegreen", "linen", "magenta", "maroon",
|
|
||||||
"mediumaquamarine", "mediumblue", "mediumorchid", "mediumpurple", "mediumseagreen",
|
|
||||||
"mediumslateblue", "mediumspringgreen", "mediumturquoise", "mediumvioletred", "midnightblue",
|
|
||||||
"mintcream", "mistyrose", "moccasin", "navajowhite", "navy", "oldlace", "olive", "olivedrab",
|
|
||||||
"orange", "orangered", "orchid", "palegoldenrod", "palegreen", "paleturquoise",
|
|
||||||
"palevioletred", "papayawhip", "peachpuff", "peru", "pink", "plum", "powderblue", "purple",
|
|
||||||
"rebeccapurple", "red", "rosybrown", "royalblue", "saddlebrown", "salmon", "sandybrown",
|
|
||||||
"seagreen", "seashell", "sienna", "silver", "skyblue", "slateblue", "slategray", "snow",
|
|
||||||
"springgreen", "steelblue", "tan", "teal", "thistle", "tomato", "transparent", "turquoise",
|
|
||||||
"violet", "wheat", "white", "whitesmoke", "yellow", "yellowgreen",
|
|
||||||
]
|
|
||||||
);
|
|
||||||
|
|
||||||
// The keys of the `$themes` and `$accents` maps and of each theme inside them: a line starting with
|
|
||||||
// `key:` or `"key":`. The custom properties of the mixins (`--color-#{$name}: #{$value};`) do not
|
|
||||||
// match, `#` is not part of a key.
|
|
||||||
const mapKeys = [...colorsSource.matchAll(/^\s*("[^"]+"|[A-Za-z][A-Za-z0-9_-]*)\s*:/gm)].map((m) => m[1]);
|
|
||||||
|
|
||||||
test("the theme and accent maps are read as maps of keys", () => {
|
|
||||||
// sanity check on the extraction above before it is trusted to find a bare colour keyword
|
|
||||||
for (const key of ["dark", "light", "katlum", "solus", "silang", "background", "text"]) {
|
|
||||||
assert.ok(mapKeys.includes(key), `expected to find the map key '${key}'`);
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
test("no map key is a bare CSS colour keyword", () => {
|
|
||||||
const bare = mapKeys.filter((key) => !key.startsWith('"') && colorKeywords.has(key.toLowerCase()));
|
|
||||||
assert.deepEqual(bare, [], `quote these colors.scss map keys so Sass keeps them strings: ${bare.join(", ")}`);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("the colour-named theme keys are quoted in both maps", () => {
|
|
||||||
for (const [key, value] of [["red", "#e06c75"], ["green", "#98c379"], ["gray", "#cccccc"]]) {
|
|
||||||
const declarations = colorsSource.match(new RegExp(`"${key}":\\s*${value}\\b`, "g")) || [];
|
|
||||||
assert.equal(declarations.length, 2, `expected quoted "${key}": ${value} in both the dark and the light map`);
|
|
||||||
}
|
|
||||||
});
|
|
||||||
Reference in New Issue
Block a user