Fix issue #51: Error when opening manage acconuts
Some checks failed
Test / test (push) Failing after 2s
Some checks failed
Test / test (push) Failing after 2s
This commit is contained in:
@@ -193,4 +193,113 @@ router.get('/get-settings', passport.authenticate('jwt', {session: false}), asyn
|
||||
}
|
||||
});
|
||||
|
||||
// -- Account management (the "Manage accounts" window of the site settings) ----
|
||||
// /api/user is mounted before the JWT guard, so every route below authenticates
|
||||
// inline; and only an administrator gets past isAdmin (services/middleware.js).
|
||||
|
||||
router.get('/list', passport.authenticate('jwt', {session: false}), isAdmin, async (req, res) => {
|
||||
try {
|
||||
// No account gets out with its password or an unfinished setup code.
|
||||
const users = await User.find().select('-password -setupCode').sort({ date: 1 });
|
||||
res.json({ status: "ok", users });
|
||||
} catch (err) {
|
||||
console.error(err);
|
||||
res.json({ status: "error", msg: "errors.internal" });
|
||||
}
|
||||
});
|
||||
|
||||
// The admin creates the account with the password its user logs in with; the
|
||||
// setupCode flow above stays as it is, nothing on the frontend completes it.
|
||||
router.post('/create', passport.authenticate('jwt', {session: false}), isAdmin, async (req, res) => {
|
||||
try {
|
||||
const { name, username, email, password } = req.body;
|
||||
if (!(name && username && email && password)) {
|
||||
return res.json({ status: "error", msg: "errors.missing-data" });
|
||||
}
|
||||
|
||||
const existingUser = await User.findOne({
|
||||
$or: [
|
||||
{ email: email },
|
||||
{ username: username }
|
||||
]
|
||||
});
|
||||
if (existingUser) {
|
||||
return res.json({
|
||||
status: "error",
|
||||
msg: "register.errors.email-username-exists"
|
||||
});
|
||||
}
|
||||
|
||||
const salt = await bcrypt.genSalt(10);
|
||||
let user = new User({
|
||||
name: name,
|
||||
username: username,
|
||||
email: email,
|
||||
password: await bcrypt.hash(password, salt)
|
||||
});
|
||||
await user.save();
|
||||
res.json({
|
||||
status: "ok",
|
||||
user: {
|
||||
_id: user._id,
|
||||
name: user.name,
|
||||
username: user.username,
|
||||
email: user.email,
|
||||
admin: user.admin,
|
||||
date: user.date
|
||||
}
|
||||
});
|
||||
} catch (err) {
|
||||
console.error(err);
|
||||
res.json({ status: "error", msg: "errors.internal" });
|
||||
}
|
||||
});
|
||||
|
||||
router.post('/set-admin', passport.authenticate('jwt', {session: false}), isAdmin, async (req, res) => {
|
||||
try {
|
||||
const { id, admin } = req.body;
|
||||
if (!id || typeof admin !== 'boolean') {
|
||||
return res.json({ status: "error", msg: "errors.missing-data" });
|
||||
}
|
||||
|
||||
// Switching one's own rights off could leave an instance with nobody who
|
||||
// can manage accounts at all, so the row for yourself stays closed.
|
||||
if (String(req.user._id) === String(id)) {
|
||||
return res.json({ status: "error", msg: "settings.site-administration.accounts.errors.self-admin" });
|
||||
}
|
||||
|
||||
const user = await User.findOne({ _id: id });
|
||||
if (!user) return res.json({ status: "error", msg: "errors.notfound" });
|
||||
|
||||
user.admin = admin;
|
||||
await user.save();
|
||||
res.json({ status: "ok", user: { _id: user._id, admin: user.admin } });
|
||||
} catch (err) {
|
||||
console.error(err);
|
||||
res.json({ status: "error", msg: "errors.internal" });
|
||||
}
|
||||
});
|
||||
|
||||
// Only the account itself goes; what it created stays as it is.
|
||||
router.post('/delete', passport.authenticate('jwt', {session: false}), isAdmin, async (req, res) => {
|
||||
try {
|
||||
const { id } = req.body;
|
||||
if (!id) return res.json({ status: "error", msg: "errors.missing-data" });
|
||||
|
||||
// Same guard as the admin switch: nobody locks themselves out on the way out.
|
||||
if (String(req.user._id) === String(id)) {
|
||||
return res.json({ status: "error", msg: "settings.site-administration.accounts.errors.self-delete" });
|
||||
}
|
||||
|
||||
const user = await User.findOne({ _id: id });
|
||||
if (!user) return res.json({ status: "error", msg: "errors.notfound" });
|
||||
|
||||
await user.deleteOne();
|
||||
res.json({ status: "ok" });
|
||||
} catch (err) {
|
||||
console.error(err);
|
||||
res.json({ status: "error", msg: "errors.internal" });
|
||||
}
|
||||
});
|
||||
|
||||
module.exports = router;
|
||||
Reference in New Issue
Block a user