From 1fab8ce20deec27f815cf8dfd6f3f5cd31d18d89 Mon Sep 17 00:00:00 2001 From: Aran Roig Date: Sun, 11 Oct 2026 22:38:59 +0200 Subject: [PATCH] Bug fix --- AGENTS.md | 9 ++++++--- frontend/app/components/viewer/TopBar.vue | 16 +++++++++++++++- frontend/app/components/viewer/content/Note.vue | 4 +++- .../components/viewer/content/NoteContainer.vue | 2 ++ frontend/i18n/locales/ca/main-menu.json | 3 ++- frontend/i18n/locales/en/main-menu.json | 3 ++- frontend/i18n/locales/es/main-menu.json | 3 ++- 7 files changed, 32 insertions(+), 8 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index 8e548bf3..54e95785 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -338,12 +338,15 @@ Every listener in the app (there are only these six `emitter.on` call sites): |---|---|---| | `toast` | `{color,text,duration}` | `ToastManager.vue` | | `push-note` | `{key,title,text,date}` | `NoteContainer.vue` | -| `delete-note` | note key (string) | `NoteContainer.vue` | +| `close-note` | note key (string) | `NoteContainer.vue` (removes the note from the open column only) | +| `delete-note` | note key (string) | `NoteContainer.vue`, `ContentSidebar.vue`, `NestedNoteList.vue` (real deletion: closes the note **and** removes it from the sidebar) | | `title-updated` | `{key,title}` | `Note.vue`, `NoteContainer.vue` | | `status-bar-update` | `{text,icon}` | `FetchStatus.vue` | -Emitters: `Toaster.js` (`toast`), `ContentSidebar` / `TopSearchBar` (`push-note`), `Note.vue` / -`NestedNoteList.vue` (`delete-note`), `ContentSidebar` (`title-updated`), `FetchStatus` (self-test emit). +Emitters: `Toaster.js` (`toast`), `ContentSidebar` / `TopSearchBar` (`push-note`), `Note.vue` +(`close-note` — the close button must not use `delete-note` or the sidebar entry disappears), +`NestedNoteList.vue` (`delete-note`, after `POST /note/delete`), `ContentSidebar` (`title-updated`), +`FetchStatus` (self-test emit). **Orphan events** — emitted, never subscribed to anywhere (the matching handlers `handleNoteCreated` / `handleNoteRenamed` exist in `ContentSidebar.vue` but were never wired with `emitter.on`; see §9.17): diff --git a/frontend/app/components/viewer/TopBar.vue b/frontend/app/components/viewer/TopBar.vue index faba5934..2d4cba90 100644 --- a/frontend/app/components/viewer/TopBar.vue +++ b/frontend/app/components/viewer/TopBar.vue @@ -1,9 +1,10 @@ @@ -65,6 +78,7 @@ function OpenCampaignSettings() { justify-content: flex-end; flex: 1; padding: 0 10px; + gap: 8px; } .settings-button { diff --git a/frontend/app/components/viewer/content/Note.vue b/frontend/app/components/viewer/content/Note.vue index 348e418f..7413296f 100644 --- a/frontend/app/components/viewer/content/Note.vue +++ b/frontend/app/components/viewer/content/Note.vue @@ -26,7 +26,9 @@ function markDirty() { } function closeNote(){ - emitter.emit('delete-note', props.noteKey); + // 'close-note' only closes the opened note; 'delete-note' is reserved for + // actual deletions (sidebar removal happens on that event instead) + emitter.emit('close-note', props.noteKey); } const compiledMarkdown = computed(() => { diff --git a/frontend/app/components/viewer/content/NoteContainer.vue b/frontend/app/components/viewer/content/NoteContainer.vue index 3d17741f..9ce4cb5e 100644 --- a/frontend/app/components/viewer/content/NoteContainer.vue +++ b/frontend/app/components/viewer/content/NoteContainer.vue @@ -47,6 +47,7 @@ function handleDeleteNote(key) { // Moure aixo onMounted(() => { emitter.on("push-note", handlePushNote); + emitter.on("close-note", handleDeleteNote); emitter.on("delete-note", handleDeleteNote); emitter.on("title-updated", handleTitleUpdated); }); @@ -60,6 +61,7 @@ function handleTitleUpdated(data) { onUnmounted(() => { emitter.off("push-note", handlePushNote); + emitter.off("close-note", handleDeleteNote); emitter.off("delete-note", handleDeleteNote); emitter.off("title-updated", handleTitleUpdated); }); diff --git a/frontend/i18n/locales/ca/main-menu.json b/frontend/i18n/locales/ca/main-menu.json index a8a5b5de..47355006 100644 --- a/frontend/i18n/locales/ca/main-menu.json +++ b/frontend/i18n/locales/ca/main-menu.json @@ -3,5 +3,6 @@ "edit-profile": "Editar perfil", "create-campaign": "Crear campanya", "log-out": "Tanca la sessió", - "settings": "Configuració" + "settings": "Configuració", + "exit": "Sortir" } \ No newline at end of file diff --git a/frontend/i18n/locales/en/main-menu.json b/frontend/i18n/locales/en/main-menu.json index 6ea584a3..b1f8c866 100644 --- a/frontend/i18n/locales/en/main-menu.json +++ b/frontend/i18n/locales/en/main-menu.json @@ -3,5 +3,6 @@ "edit-profile": "Edit profile", "create-campaign": "Create Campaign", "log-out": "Log out", - "settings": "Settings" + "settings": "Settings", + "exit": "Exit" } \ No newline at end of file diff --git a/frontend/i18n/locales/es/main-menu.json b/frontend/i18n/locales/es/main-menu.json index eeb958c4..3881bc27 100644 --- a/frontend/i18n/locales/es/main-menu.json +++ b/frontend/i18n/locales/es/main-menu.json @@ -3,5 +3,6 @@ "edit-profile": "Editar perfil", "create-campaign": "Crear campanya", "log-out": "Cerrar sesión", - "settings": "Configuración" + "settings": "Configuración", + "exit": "Salir" } \ No newline at end of file