Fix issue #19: Add unified campaign sync
This commit is contained in:
@@ -1,124 +1,25 @@
|
||||
const crypto = require('node:crypto');
|
||||
const express = require('express');
|
||||
const passport = require('passport');
|
||||
const router = express.Router();
|
||||
|
||||
const Actor = require('../models/Actor');
|
||||
const Campaign = require('../models/Campaign');
|
||||
const DiscordGuildLink = require('../models/DiscordGuildLink');
|
||||
const DiscordLinkRequest = require('../models/DiscordLinkRequest');
|
||||
const ServiceLinkRequest = require('../models/ServiceLinkRequest');
|
||||
const User = require('../models/User');
|
||||
const serviceLinks = require('../services/service-links');
|
||||
|
||||
const LINK_TTL_MS = 10 * 60 * 1000;
|
||||
const NOTIFICATION_WINDOW_MS = 15 * 60 * 1000;
|
||||
const NOTIFICATION_LIMIT = 10;
|
||||
|
||||
const requireBot = serviceLinks.requireDiscordBot;
|
||||
|
||||
function validGuildId(value) {
|
||||
return /^\d{5,25}$/.test(String(value ?? ''));
|
||||
}
|
||||
|
||||
function codeHash(code) {
|
||||
return crypto.createHash('sha256').update(String(code ?? '')).digest('hex');
|
||||
}
|
||||
|
||||
function requireBot(req, res, next) {
|
||||
const configuredSecret = process.env.DRAGONROLL_DISCORD_BOT_SECRET?.trim() || '';
|
||||
const suppliedSecret = req.get('x-dragonroll-discord-bot-secret') || '';
|
||||
const expected = Buffer.from(configuredSecret);
|
||||
const supplied = Buffer.from(suppliedSecret);
|
||||
|
||||
if (!expected.length || expected.length !== supplied.length || !crypto.timingSafeEqual(expected, supplied)) {
|
||||
return res.status(401).json({ status: 'error', msg: 'errors.unauthorized' });
|
||||
}
|
||||
return next();
|
||||
}
|
||||
|
||||
function frontendAuthorizeUrl() {
|
||||
const frontendUrl = (process.env.DRAGONROLL_FRONTEND_URL || 'http://localhost:3000').trim().replace(/\/+$/, '');
|
||||
return `${frontendUrl}/discord/authorize`;
|
||||
}
|
||||
|
||||
// La pantalla d'autorització l'serveix el frontend. El codi viatja al fragment de la URL i el
|
||||
// navegador no l'envia mai al servidor, així que els enllaços antics del bot arriben a la
|
||||
// pantalla sense codi i demanen de tornar a executar /dragonroll connect.
|
||||
router.get('/authorize', (req, res) => {
|
||||
res.set('Cache-Control', 'no-store');
|
||||
res.set('Referrer-Policy', 'no-referrer');
|
||||
res.set('X-Content-Type-Options', 'nosniff');
|
||||
res.redirect(302, frontendAuthorizeUrl());
|
||||
});
|
||||
|
||||
router.post('/link/start', requireBot, async (req, res) => {
|
||||
try {
|
||||
const { guildId, guildName, discordUserId, discordUserName } = req.body;
|
||||
if (!validGuildId(guildId) || !/^\d{5,25}$/.test(String(discordUserId ?? '')) || !guildName || !discordUserName) {
|
||||
return res.json({ status: 'error', msg: 'errors.missing-data' });
|
||||
}
|
||||
|
||||
const code = crypto.randomBytes(32).toString('base64url');
|
||||
await DiscordLinkRequest.create({
|
||||
codeHash: codeHash(code),
|
||||
guildId: String(guildId),
|
||||
guildName: String(guildName).slice(0, 100),
|
||||
discordUserId: String(discordUserId),
|
||||
discordUserName: String(discordUserName).slice(0, 100),
|
||||
expiresAt: new Date(Date.now() + LINK_TTL_MS)
|
||||
});
|
||||
|
||||
res.json({ status: 'ok', code, expiresAt: new Date(Date.now() + LINK_TTL_MS) });
|
||||
} catch (err) {
|
||||
console.error(err);
|
||||
res.json({ status: 'error', msg: 'errors.internal' });
|
||||
}
|
||||
});
|
||||
|
||||
router.post('/link/details', async (req, res) => {
|
||||
try {
|
||||
res.set('Cache-Control', 'no-store');
|
||||
const request = await DiscordLinkRequest.findOne({
|
||||
codeHash: codeHash(req.body.code),
|
||||
expiresAt: { $gt: new Date() },
|
||||
completedAt: null
|
||||
}).lean();
|
||||
if (!request) return res.json({ status: 'error', msg: 'discord.errors.link-expired' });
|
||||
|
||||
res.json({ status: 'ok', guildName: request.guildName, discordUserName: request.discordUserName });
|
||||
} catch (err) {
|
||||
console.error(err);
|
||||
res.json({ status: 'error', msg: 'errors.internal' });
|
||||
}
|
||||
});
|
||||
|
||||
router.post('/link/complete', passport.authenticate('jwt', { session: false }), async (req, res) => {
|
||||
try {
|
||||
const request = await DiscordLinkRequest.findOneAndUpdate({
|
||||
codeHash: codeHash(req.body.code),
|
||||
expiresAt: { $gt: new Date() },
|
||||
completedAt: null
|
||||
}, {
|
||||
$set: { completedAt: new Date(), dragonrollUser: req.user.id }
|
||||
}, { new: true });
|
||||
if (!request) return res.json({ status: 'error', msg: 'discord.errors.link-expired' });
|
||||
|
||||
await Campaign.updateMany(
|
||||
{ discordGuildId: request.guildId, createdBy: { $ne: req.user.id } },
|
||||
{ $unset: { discordGuildId: 1 } }
|
||||
);
|
||||
|
||||
await DiscordGuildLink.findOneAndUpdate({ guildId: request.guildId }, {
|
||||
$set: {
|
||||
discordUserId: request.discordUserId,
|
||||
dragonrollUser: req.user.id,
|
||||
connectedAt: new Date()
|
||||
}
|
||||
}, { new: true, upsert: true, setDefaultsOnInsert: true });
|
||||
|
||||
res.json({ status: 'ok', guildName: request.guildName });
|
||||
} catch (err) {
|
||||
console.error(err);
|
||||
res.json({ status: 'error', msg: 'errors.internal' });
|
||||
}
|
||||
});
|
||||
// Connecting a Discord server is the service link of issue: the bot asks
|
||||
// /api/link/start for a sign-up link, and whoever opens it signs in and picks the
|
||||
// campaign this server may read. What is left here is what the bot needs once
|
||||
// that link exists: confirming it in Discord and working with its campaign.
|
||||
|
||||
async function dragonrollUserNames(requests) {
|
||||
const userIds = [...new Set(requests.map((request) => String(request.dragonrollUser ?? '')).filter(Boolean))];
|
||||
@@ -132,16 +33,18 @@ async function dragonrollUserNames(requests) {
|
||||
// mateix evita que dos processos del bot confirmïn la mateixa vegada.
|
||||
router.post('/bot/link-requests/notifications', requireBot, async (req, res) => {
|
||||
try {
|
||||
const pending = await DiscordLinkRequest.find({
|
||||
completedAt: { $gte: new Date(Date.now() - NOTIFICATION_WINDOW_MS) },
|
||||
const pending = await ServiceLinkRequest.find({
|
||||
service: 'discord',
|
||||
state: 'linked',
|
||||
linkedAt: { $gte: new Date(Date.now() - serviceLinks.NOTIFICATION_WINDOW_MS) },
|
||||
notifiedAt: null
|
||||
}).select('_id guildId guildName discordUserId discordUserName dragonrollUser')
|
||||
}).select('_id targetId targetName targetUser targetMeta dragonrollUser campaign')
|
||||
.limit(NOTIFICATION_LIMIT)
|
||||
.lean();
|
||||
|
||||
const claimed = [];
|
||||
for (const request of pending) {
|
||||
const taken = await DiscordLinkRequest.findOneAndUpdate(
|
||||
const taken = await ServiceLinkRequest.findOneAndUpdate(
|
||||
{ _id: request._id, notifiedAt: null },
|
||||
{ $set: { notifiedAt: new Date() } },
|
||||
{ new: true }
|
||||
@@ -150,15 +53,22 @@ router.post('/bot/link-requests/notifications', requireBot, async (req, res) =>
|
||||
}
|
||||
|
||||
const names = await dragonrollUserNames(claimed);
|
||||
const campaignIds = [...new Set(claimed.map((request) => String(request.campaign ?? '')).filter(Boolean))];
|
||||
const campaigns = campaignIds.length
|
||||
? await Campaign.find({ _id: { $in: campaignIds } }).select('_id name').lean()
|
||||
: [];
|
||||
const campaignNames = new Map(campaigns.map((campaign) => [String(campaign._id), campaign.name]));
|
||||
|
||||
res.json({
|
||||
status: 'ok',
|
||||
notifications: claimed.map((request) => ({
|
||||
id: String(request._id),
|
||||
guildId: request.guildId,
|
||||
guildName: request.guildName,
|
||||
discordUserId: request.discordUserId,
|
||||
discordUserName: request.discordUserName,
|
||||
dragonrollUserName: names.get(String(request.dragonrollUser ?? '')) || null
|
||||
guildId: request.targetId,
|
||||
guildName: request.targetName,
|
||||
discordUserId: request.targetMeta?.userId || '',
|
||||
discordUserName: request.targetUser,
|
||||
dragonrollUserName: names.get(String(request.dragonrollUser ?? '')) || null,
|
||||
campaignName: campaignNames.get(String(request.campaign ?? '')) || null
|
||||
}))
|
||||
});
|
||||
} catch (err) {
|
||||
|
||||
Reference in New Issue
Block a user