-
-
- {{ $t('campaigns.item.quantity') }}
- - {{ form.quantity }}
-
- {{ $t('campaigns.item.weight') }}
- {{ Number(form.weight).toFixed(1) }} lb
diff --git a/frontend/i18n/locales/ca/campaigns.json b/frontend/i18n/locales/ca/campaigns.json
index 33097529..0c24a925 100644
--- a/frontend/i18n/locales/ca/campaigns.json
+++ b/frontend/i18n/locales/ca/campaigns.json
@@ -65,8 +65,8 @@
},
"item": {
"new": "Objecte nou", "edit": "Edita l'objecte", "foundry-sync-note": "Els canvis en aquest objecte també s'apliquen al món del Foundry vinculat.",
- "category": "Categoria", "rarity": "Raresa", "quantity": "Quantitat",
- "quantity-short": "Quant.", "weight": "Pes (lb)", "properties": "Propietats", "properties-placeholder": "Per exemple, versàtil, subtil",
+ "category": "Categoria", "rarity": "Raresa",
+ "weight": "Pes (lb)", "properties": "Propietats", "properties-placeholder": "Per exemple, versàtil, subtil",
"sheet": {
"icon": "Icona de l'objecte", "choose-icon": "Tria la teva pròpia icona", "change-icon": "Canvia la icona",
"uploading": "Pujant...", "upload-error": "No s'ha pogut pujar aquesta icona.",
diff --git a/frontend/i18n/locales/en/campaigns.json b/frontend/i18n/locales/en/campaigns.json
index 05c6508c..41f003be 100644
--- a/frontend/i18n/locales/en/campaigns.json
+++ b/frontend/i18n/locales/en/campaigns.json
@@ -69,8 +69,8 @@
},
"item": {
"new": "New item", "edit": "Edit item", "foundry-sync-note": "Changes to this item are also applied in the linked Foundry world.",
- "category": "Category", "rarity": "Rarity", "quantity": "Quantity",
- "quantity-short": "Qty", "weight": "Weight (lb)", "properties": "Properties", "properties-placeholder": "For example, versatile, finesse",
+ "category": "Category", "rarity": "Rarity",
+ "weight": "Weight (lb)", "properties": "Properties", "properties-placeholder": "For example, versatile, finesse",
"sheet": {
"icon": "Item icon", "choose-icon": "Choose your own icon", "change-icon": "Change icon",
"uploading": "Uploading...", "upload-error": "Unable to upload this icon.",
diff --git a/frontend/i18n/locales/es/campaigns.json b/frontend/i18n/locales/es/campaigns.json
index e87cf653..d65d1c3a 100644
--- a/frontend/i18n/locales/es/campaigns.json
+++ b/frontend/i18n/locales/es/campaigns.json
@@ -65,8 +65,8 @@
},
"item": {
"new": "Nuevo objeto", "edit": "Editar objeto", "foundry-sync-note": "Los cambios en este objeto también se aplican al mundo de Foundry vinculado.",
- "category": "Categoría", "rarity": "Rareza", "quantity": "Cantidad",
- "quantity-short": "Cant.", "weight": "Peso (lb)", "properties": "Propiedades", "properties-placeholder": "Por ejemplo, versátil, sutil",
+ "category": "Categoría", "rarity": "Rareza",
+ "weight": "Peso (lb)", "properties": "Propiedades", "properties-placeholder": "Por ejemplo, versátil, sutil",
"sheet": {
"icon": "Icono del objeto", "choose-icon": "Elegir tu propio icono", "change-icon": "Cambiar icono",
"uploading": "Subiendo...", "upload-error": "No se pudo subir este icono.",
diff --git a/tests/item-rarity-entry.test.js b/tests/item-rarity-entry.test.js
new file mode 100644
index 00000000..2c697651
--- /dev/null
+++ b/tests/item-rarity-entry.test.js
@@ -0,0 +1,89 @@
+// Tests for Syndria98/dragonroll#63: the item rows in the campaign sidebar dropped the text
+// listing category, rarity and quantity — the rarity colours the text of the entry instead
+// (common white, uncommon green, rare blue, very rare purple, legendary orange) — and the
+// quantity left the item surfaces altogether, since it only belongs to an actor's inventory.
+//
+// The repository root installs no dependencies, so these read the sources the way
+// tests/item-entry-display.test.js does — the checks are about the markup and style.
+//
+// Run with `npm test` from the repository root, or `node --test tests/`.
+
+const { test } = require("node:test");
+const assert = require("node:assert/strict");
+const fs = require("node:fs");
+const path = require("node:path");
+
+const read = (...parts) => fs.readFileSync(path.join(__dirname, "..", ...parts), "utf8");
+
+const sidebarSource = read("frontend", "app", "components", "partials", "ContentSidebar.vue");
+const itemWindowSource = read("frontend", "app", "components", "windows", "ItemSheetWindow.vue");
+const entryFormSource = read("frontend", "app", "components", "windows", "CreateCampaignEntryWindow.vue");
+const sheetSource = read("frontend", "app", "components", "windows", "CharacterSheetWindow.vue");
+const colorsSource = read("frontend", "app", "assets", "css", "colors.scss");
+
+// The block that renders the item rows, as in tests/item-entry-display.test.js.
+const itemSection =
+ /([\s\S]*?)<\/template>\s*\n\s*/.exec(sidebarSource)?.[1] ?? "";
+
+const rarities = ["common", "uncommon", "rare", "very-rare", "legendary"];
+
+// `selector` is inserted verbatim, so escape the `.` of a class combination. Comments are dropped:
+// they explain a rule, they are not part of it.
+function ruleFor(selector) {
+ const rule = new RegExp(`\\.${selector}\\s*\\{([^}]*)\\}`).exec(sidebarSource)?.[0];
+ return rule?.replace(/\/\*[\s\S]*?\*\//g, "");
+}
+
+test("the item entry no longer lists the category, rarity and quantity as text", () => {
+ assert.ok(itemSection, "expected to find the items section of the sidebar");
+ assert.doesNotMatch(itemSection, /entity-entry-meta/, "the item row must not render a meta line");
+ assert.doesNotMatch(itemSection, /campaigns\.item\.(categories|rarities|quantity)/, "the item row must not render item meta text");
+ assert.doesNotMatch(sidebarSource, /itemSummary/, "the removed summary helper must not be kept around");
+});
+
+test("the rarity of an item picks a class for the text of its entry", () => {
+ assert.match(
+ itemSection,
+ / {
+ for (const rarity of rarities) {
+ const rule = ruleFor(`entity-entry-name\\.rarity-${rarity}`);
+ assert.ok(rule, `expected a colour rule for .entity-entry-name.rarity-${rarity}`);
+ assert.match(rule, new RegExp(`color:\\s*var\\(--color-rarity-${rarity}\\)`));
+ }
+});
+
+test("both theme maps carry the rarity colours", () => {
+ for (const rarity of rarities) {
+ const declarations = colorsSource.match(new RegExp(`rarity-${rarity}:\\s*#[0-9a-fA-F]{6}`, "g")) || [];
+ assert.equal(declarations.length, 2, `expected rarity-${rarity} in both the dark and the light map`);
+ }
+});
+
+test("the quantity only shows in an actor's inventory", () => {
+ assert.doesNotMatch(itemWindowSource, /quantity/, "the item window must not list the quantity");
+ assert.doesNotMatch(entryFormSource, /quantity/, "the item create/edit form must not offer the quantity");
+ // the character sheet's inventory table keeps it.
+ assert.match(sheetSource, /campaigns\.character-sheet\.quantity/);
+ assert.match(sheetSource, /\{\{ item\.quantity \}\}/);
+});
+
+test("no locale keeps the removed item quantity strings", () => {
+ for (const locale of ["en", "es", "ca"]) {
+ const campaigns = JSON.parse(read("frontend", "i18n", "locales", locale, "campaigns.json"));
+ assert.ok(campaigns.item, `${locale} is missing the campaigns.item block`);
+ assert.equal(campaigns.item.quantity, undefined, `${locale} still has campaigns.item.quantity`);
+ assert.equal(campaigns.item["quantity-short"], undefined, `${locale} still has campaigns.item.quantity-short`);
+ // the character sheet's inventory keeps its own quantity column label
+ assert.ok(campaigns["character-sheet"]?.quantity, `${locale} is missing campaigns.character-sheet.quantity`);
+ }
+});
diff --git a/tests/item-sheet-window.test.js b/tests/item-sheet-window.test.js
index 07d55c40..fc7deda6 100644
--- a/tests/item-sheet-window.test.js
+++ b/tests/item-sheet-window.test.js
@@ -73,10 +73,12 @@ test("the item info window is registered and opens on a sidebar click", () => {
});
test("the item window shows the info and offers both icon sources", () => {
- // info: name, category, rarity, quantity, weight, properties, description
- for (const key of ["form.name", "form.category", "form.rarity", "form.quantity", "form.weight", "form.properties", "form.description"]) {
+ // info: name, category, rarity, weight, properties, description — quantity is gone
+ // (#63 keeps it for the actors' inventories).
+ for (const key of ["form.name", "form.category", "form.rarity", "form.weight", "form.properties", "form.description"]) {
assert.ok(itemWindowSource.includes(key), `expected the window to render ${key}`);
}
+ assert.doesNotMatch(itemWindowSource, /quantity/, "the item window must not list the quantity");
// own icon: upload through the item route like the character sheet does its photo
assert.match(itemWindowSource, /\/item\/upload-image\?item=/);
// Foundry icon: switch the item image back to the one the world sent